Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
BuilderBase._adjustixes()
to try converting the files arguments to path string - in a way that doesn't flip an existing SCons Node back to a string.Unittest for
_adjustixes
is added to validate.Fixes #4398
Open question:
A similar change in
.src_builder_sources()
may be needed, but the context here allows just usingstr()
if needed, like:Not sure at the moment how to force something down this code path so can check - comments welcome.
Contributor Checklist:
CHANGES.txt
(and read theREADME.rst
)