add container cypress tests for openAsModal, Drawer and Splitview #4004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentUllal
changed the title
walmazacn
reviewed
Oct 31, 2024
| .click(); | ||
|
|
||
| cy.location().should(loc => { | ||
| expect(loc.href).to.eq('http://localhost:8080/iframe/iframeContainer.html#openAsModal-iframe'); |
There was a problem hiding this comment.
I think it's safer to check only hash instead of full url - it also relates to test cases below
There was a problem hiding this comment.
makes sense, thanks :)
VincentUllal
requested review from
hardl,
JohannesDoberer,
ndricimrr,
smahati and
amilewskaa
as code owners
walmazacn
reviewed
Nov 6, 2024
container/test-app/wc/clientAPI.html
Outdated
| @@ -84,6 +84,7 @@ <h3> | |||
|
|
|||
| [...document.querySelectorAll('luigi-container')].forEach(luigiContainer => { | |||
| luigiContainer.addEventListener(MFEventID.NAVIGATION_REQUEST, event => { | |||
| // alert("NAVIGATION_REQUEST received"); | |||
There was a problem hiding this comment.
This alert might be removed - same applies to line 115
There was a problem hiding this comment.
oops missed these, thanks 👍
walmazacn
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
added cypress container tests for openAsModal, openAsDrawer, openAsSplitview
Related issue(s)
resolved #4003