MBT upgrade build parameter ignore attribute #1050

young-yang03 · 2023-05-18T08:18:24Z

Description

MBT upgrade build parameter ignore attribute to support full Glob Pattern

https://wiki.one.int.sap/wiki/pages/viewpage.action?spaceKey=LCNCBJ&title=MBT+Support+Package+Specified+Content+into+MTA+archive

Checklist

Code compiles correctly
Relevant tests were added (unit / contract / integration)
Relevant logs were added
Formatting and linting run locally successfully
All tests pass
UA review
Design is documented
Extended the README / documentation, if necessary
Open source is approved

modified: internal/archive/mta_location.go new file: micromatch/micromatch-wrapper.js new file: micromatch/package-lock.json new file: micromatch/package.json new file: micromatch/run_test.sh new file: micromatch/test-micromatch.js new file: micromatch/test_micromatch_for_mta.go new file: micromatch/test_micromatch_wrapper_bin.go new file: micromatch/test_micromatch_wrapper_js.go

modified: internal/archive/fsops.go modified: micromatch/micromatch-wrapper.js modified: micromatch/test_micromatch_wrapper_bin.go modified: micromatch/test_micromatch_wrapper_js.go

modified: micromatch/test_micromatch_wrapper_bin.go modified: micromatch/test_micromatch_wrapper_js.go

modified: internal/archive/fsops.go modified: internal/archive/fsops_test.go modified: internal/artifacts/module_arch.go modified: internal/artifacts/module_arch_test.go modified: internal/artifacts/mtar.go modified: internal/commands/commands.go modified: internal/platform/model.go modified: micromatch/micromatch-wrapper.js modified: micromatch/run_test.sh modified: micromatch/test-micromatch.js deleted: micromatch/test_micromatch_for_mta.go modified: micromatch/test_micromatch_wrapper_js.go

modified: internal/archive/fsops_test.go modified: micromatch/micromatch-wrapper.js modified: micromatch/test-micromatch.js modified: micromatch/test_micromatch_wrapper_js.go

modified: micromatch/test-micromatch.js

modified: internal/archive/fsops_test.go new file: internal/archive/testdata/testignorewithsymlink/another_content/symlink_to_test4.txt new file: internal/archive/testdata/testignorewithsymlink/another_content/test3.txt new file: internal/archive/testdata/testignorewithsymlink/clean-symlink-env.bat new file: internal/archive/testdata/testignorewithsymlink/content/symlink_dir_to_another_content new file: internal/archive/testdata/testignorewithsymlink/content/test.txt new file: internal/archive/testdata/testignorewithsymlink/content/test_dir/test1.txt new file: internal/archive/testdata/testignorewithsymlink/dir_with_recursive_symlink/subdir/symlink_dir_recursion_to_parent_dir new file: internal/archive/testdata/testignorewithsymlink/dir_with_recursive_symlink/subdir/symlink_dir_to_sibling new file: internal/archive/testdata/testignorewithsymlink/dir_with_recursive_symlink/subdir2/symlink_dir_to_sibling new file: internal/archive/testdata/testignorewithsymlink/moduleNew/package.json new file: internal/archive/testdata/testignorewithsymlink/moduleNew/symlink_dir_to_content new file: internal/archive/testdata/testignorewithsymlink/prepare-symlink-env.bat new file: internal/archive/testdata/testignorewithsymlink/symlink_dir_to_moduleNew new file: internal/archive/testdata/testignorewithsymlink/symlink_dir_to_symlink_dir_broken new file: internal/archive/testdata/testignorewithsymlink/symlink_to_symlink_broken new file: internal/archive/testdata/testignorewithsymlink/test4.txt modified: internal/artifacts/module_arch.go modified: internal/artifacts/mtar.go

modified: internal/archive/fsops.go modified: internal/archive/fsops_test.go new file: internal/archive/testdata/testproject/ui5app/webapp/view/.invisibleView

new file: cmd/testdata/mtaignore/mta-ignore-node_modules-subfolders.yaml new file: cmd/testdata/mtaignore/node-js/gulpfile.js new file: cmd/testdata/mtaignore/node-js/package-lock.json new file: cmd/testdata/mtaignore/node-js/package.json new file: cmd/testdata/mtaignore/node-js/server.js

modified: cmd/build_parameter_test.go modified: cmd/cmd_test.go modified: cmd/init.go modified: internal/archive/fsops.go deleted: internal/archive/testdata/testignorewithsymlink/another_content/symlink_to_test4.txt deleted: internal/archive/testdata/testignorewithsymlink/content/symlink_dir_to_another_content deleted: internal/archive/testdata/testignorewithsymlink/dir_with_recursive_symlink/subdir/symlink_dir_recursion_to_parent_dir deleted: internal/archive/testdata/testignorewithsymlink/dir_with_recursive_symlink/subdir/symlink_dir_to_sibling deleted: internal/archive/testdata/testignorewithsymlink/dir_with_recursive_symlink/subdir2/symlink_dir_to_sibling deleted: internal/archive/testdata/testignorewithsymlink/moduleNew/symlink_dir_to_content deleted: internal/archive/testdata/testignorewithsymlink/symlink_dir_to_moduleNew deleted: internal/archive/testdata/testignorewithsymlink/symlink_dir_to_symlink_dir_broken deleted: internal/archive/testdata/testignorewithsymlink/symlink_to_symlink_broken modified: package-lock.json

modified: internal/archive/fsops.go deleted: internal/artifacts/testdata/mtahtml5/.mtahtml5_mta_build_tmp/xs-security.json new file: micromatch/build-install-test.sh new file: micromatch/build-install.sh modified: micromatch/micromatch-wrapper.js new file: micromatch/node-js/gulpfile.js new file: micromatch/node-js/package.json new file: micromatch/node-js/server.js deleted: micromatch/run_test.sh new file: micromatch/test.sh modified: micromatch/test_micromatch_wrapper_js.go

modified: .goreleaser.yml modified: Dockerfile_mbtci_template modified: cmd/init_test.go modified: cmd/testdata/mta/mta.yaml modified: integration/cloud_mta_build_tool_test.go modified: internal/archive/fsops_test.go new file: micromatch/Darwin/micromatch-wrapper new file: micromatch/Linux/micromatch-wrapper new file: micromatch/Windows/micromatch-wrapper.exe modified: micromatch/build-install.sh modified: package.json

modified: index.js

modified: micromatch/Darwin/micromatch-wrapper modified: micromatch/Linux/micromatch-wrapper modified: micromatch/Windows/micromatch-wrapper.exe modified: package-lock.json

modified: cmd/build_parameter_test.go modified: cmd/init_test.go modified: micromatch/Darwin/micromatch-wrapper modified: micromatch/Linux/micromatch-wrapper modified: micromatch/Windows/micromatch-wrapper.exe

modified: cmd/init_test.go

modified: cmd/build_parameter_test.go

modified: cmd/init_test.go

modified: Dockerfile_mbtci_template modified: cmd/init_test.go

modified: Makefile modified: test/goss/goss_template.yaml

modified: configs/builder_type_cfg.yaml

ShiraManas · 2023-07-05T11:29:34Z

docs/docs/micromatch-wrapper.md

+
+   - [Download](https://github.com/SAP/cloud-mta-build-tool/releases) the latest source code.
+
+   - Install [pkg](https://github.com/vercel/pkg/) on your operating system


Install pkg on your operating system:

ShiraManas · 2023-07-05T11:30:40Z

docs/docs/micromatch-wrapper.md

+npm install -g pkg
+```
+
+   - Build micromatch wrapper under `micromatch` subfolder of source code


Build the micromatch wrapper under the micromatch subfolder of the source code:

ShiraManas · 2023-07-05T11:32:22Z

docs/docs/micromatch-wrapper.md

+```
+   - Add the binary file to your `~/bin` path according to your operating system:  
+
+     * In Darwin, copy binary file `micromatch-wrapper` to the `~/usr/local/bin/` folder, for example: `cp micromatch-wrapper-macos /usr/local/bin/micromatch-wrapper`


In Darwin, copy the micromatch-wrapper binary file to the ~/usr/local/bin/ folder.
Here is a sample command: cp micromatch-wrapper-macos /usr/local/bin/micromatch-wrapper

ShiraManas · 2023-07-05T11:33:21Z

docs/docs/micromatch-wrapper.md

+
+     * In Darwin, copy binary file `micromatch-wrapper` to the `~/usr/local/bin/` folder, for example: `cp micromatch-wrapper-macos /usr/local/bin/micromatch-wrapper`
+
+     * In Linux, copy binary file `micromatch-wrapper` to the `~/usr/local/bin/` folder, for example: `cp micromatch-wrapper-linux /usr/local/bin/micromatch-wrapper`


In Linux, copy the micromatch-wrapper binary file to the ~/usr/local/bin/ folder.
Here is a sample command: cp micromatch-wrapper-linux /usr/local/bin/micromatch-wrapper

ShiraManas · 2023-07-05T11:35:58Z

docs/docs/micromatch-wrapper.md

+
+**Install using npm**
+
+Run the command below, it will install mbt and micromatch-wrapper together


Run the command below to install MBT and the micromatch wrapper together:

ShiraManas · 2023-07-05T11:44:36Z

docs/docs/whatsnew.md

@@ -41,3 +41,24 @@ If you want to use the old `mvn -B package` command instead of the `maven` build
 ```

 The same approach can be implemented if the `maven` builder is used in the global build step.
+
+## v1.2.25
+The build-parameters ignore attribute will be upgraded to support [Full Glob Pattern](https://en.wikipedia.org/wiki/Glob_(programming)). 


The 'build-parameters ignore' attribute will be upgraded to support glob patterns.

ShiraManas · 2023-07-05T11:47:31Z

docs/docs/whatsnew.md

+## v1.2.25
+The build-parameters ignore attribute will be upgraded to support [Full Glob Pattern](https://en.wikipedia.org/wiki/Glob_(programming)). 
+
+Wildcards, such as `*`,`!`,`?` can be used to match characters. You can package specified content by using negation pattern `!`


Wildcards, such as *,!,? can be used to match characters. You can package specific content by using the ! negation pattern.
(Is there a mistake? How can it be that ! is used to match and to negate?
Also, can we say "select specific content" in the second sentence above instead of "package specified content"? Is this correct?)

By using negation pattern ! in the build-parameters ignore attribute, because not ignore equal to include, you can select specified content into the package.

ShiraManas · 2023-07-05T11:50:49Z

docs/docs/whatsnew.md

+     build-result: myfolder
+     ignore: ["node_modules/**", "!node_modules/mtainclude"]
+
+# In this example, all files and subfolders of node_modules will not be packaged in to MTA archive


In this example, all files and subfolders of 'node_modules' will not be packaged into the MTA archive, except for the 'mtainclude' subfolder of 'node_modules'.

ShiraManas

Hi. I've added some suggestions here.

modified: internal/artifacts/module_arch.go modified: internal/artifacts/mtar.go

modified: docs/docs/download.md modified: docs/docs/micromatch-wrapper.md modified: docs/docs/whatsnew.md

young-yang03 · 2023-07-10T03:55:34Z

@ShiraManas I recommit the documents, pls review it, thanks

ShiraManas · 2023-07-10T11:40:39Z

docs/docs/configuration.md

@@ -204,6 +204,23 @@ For example:
 # In this example, the following will not be packaged in to MTA archive:
 # all files with the"txt" extension and the "mtaignore" folder within the "myfolder" directory. 

+```
+From MBT 1.2.25 version, the `build-parameters ignore` attribute will be upgraded to support [full glob pattern](https://en.wikipedia.org/wiki/Glob_(programming)). Wildcards, such as `*`,`!`,`?` can be used to match characters. 


-From the MBT 1.2.25 version,
-"full glob patterns" instead of "full glob pattern"

ShiraManas · 2023-07-10T11:44:58Z

docs/docs/download.md

@@ -32,3 +32,6 @@ Run the command below.
 npm install -g mbt
 ```

+From MBT 1.2.25 version, the `build-parameters ignore` attribute will be upgraded to support [full glob patterns](https://en.wikipedia.org/wiki/Glob_(programming)). You must install the micromatch wrapper to use the glob patterns.
+
+You can install micromatch-wrapp by instruction [Here](https://github.com/SAP/cloud-mta-build-tool/tree/master/docs/docs/micromatch-wrapper.md)


Follow the instructions to install the micromatch wrapper.

ShiraManas · 2023-07-10T11:51:49Z

docs/docs/micromatch-wrapper.md

@@ -0,0 +1,52 @@
+#### Overview
+[Micromatch](https://github.com/micromatch/micromatch) support various matching features, such as glob patterns and advanced globbing


Just add the missing period at the end of the sentence:
Micromatch support various matching features, such as glob patterns and advanced globbing.

ShiraManas · 2023-07-10T11:53:21Z

docs/docs/micromatch-wrapper.md

+#### Overview
+[Micromatch](https://github.com/micromatch/micromatch) support various matching features, such as glob patterns and advanced globbing
+
+Micromatch is a Node.js application, while MBT is a Go application. The micromatch wrapper is a package that enables MBT to use the functionalities provided by micromatch. From MBT 1.2.25 version, we create [micromath wrapper](https://github.com/SAP/cloud-mta-build-tool/tree/master/micromatch) to package it.


From the MBT 1.2.25 version, we provide the micromatch wrapper to package it.

ShiraManas · 2023-07-10T11:57:04Z

docs/docs/configuration.md

+```
+From MBT 1.2.25 version, the `build-parameters ignore` attribute will be upgraded to support [full glob pattern](https://en.wikipedia.org/wiki/Glob_(programming)). Wildcards, such as `*`,`!`,`?` can be used to match characters. 
+
+By using negation pattern `!` in the `build-parameters ignore` attribute, because `not ignore` equal to `include`, it means you can select specified content into the package.


By using the ! negation pattern in the build-parameters ignore attribute, you can select specified content into the package (because not ignore equals include).

ShiraManas · 2023-07-10T11:58:00Z

docs/docs/download.md

@@ -32,3 +32,6 @@ Run the command below.
 npm install -g mbt
 ```

+From MBT 1.2.25 version, the `build-parameters ignore` attribute will be upgraded to support [full glob patterns](https://en.wikipedia.org/wiki/Glob_(programming)). You must install the micromatch wrapper to use the glob patterns.


From the MBT 1.2.25 version,

ShiraManas · 2023-07-10T12:00:46Z

docs/docs/whatsnew.md

@@ -41,3 +41,23 @@ If you want to use the old `mvn -B package` command instead of the `maven` build
 ```

 The same approach can be implemented if the `maven` builder is used in the global build step.
+
+## v1.2.25
+The `build-parameters ignore` attribute will be upgraded to support [full glob pattern](https://en.wikipedia.org/wiki/Glob_(programming)). Wildcards, such as `*`,`!`,`?` can be used to match characters. 


The build-parameters ignore attribute will be upgraded to support full glob patterns.

ShiraManas · 2023-07-10T12:01:39Z

docs/docs/whatsnew.md

+## v1.2.25
+The `build-parameters ignore` attribute will be upgraded to support [full glob pattern](https://en.wikipedia.org/wiki/Glob_(programming)). Wildcards, such as `*`,`!`,`?` can be used to match characters. 
+
+By using negation pattern `!` in the `build-parameters ignore` attribute, because `not ignore` equal to `include`, it means you can select specified content into the package.


By using the ! negation pattern in the build-parameters ignore attribute, you can select specified content into the package (because not ignore equal to include).

OK, my recommit just a little different with your suggestion.

To be consistent with the front， equal to -> equals

ShiraManas

Looks much better! Added my last few comments here.

modified: cmd/testdata/mta/mta.yaml new file: cmd/testdata/mtaignore/mta-ignore-all-invisible-dir-and-files.yaml modified: cmd/testdata/mtaignore/mta-ignore-all-node_modules.yaml modified: cmd/testdata/mtaignore/mta-ignore-node_modules-subfolders.yaml new file: cmd/testdata/mtaignore/node-js/.invisible-file new file: cmd/testdata/mtaignore/node-js/.invisibledir-1/.invisible-file-1 new file: cmd/testdata/mtaignore/node-js/.invisibledir-2/visible-file-2 modified: internal/artifacts/module_arch.go modified: internal/artifacts/mtar.go modified: micromatch/test-micromatch.js

…les.yaml modified: cmd/testdata/mtaignore/mta-ignore-all-node_modules.yaml modified: cmd/testdata/mtaignore/mta-ignore-node_modules-subfolders.yaml renamed: cmd/testdata/mtaignore/node-js/.invisibledir-1/.invisible-file-1 -> cmd/testdata/mtaignore/node-js/.invisible-dir/.invisible-file renamed: cmd/testdata/mtaignore/node-js/.invisibledir-2/visible-file-2 -> cmd/testdata/mtaignore/node-js/.invisible-dir/.invisible-sub-dir/.invisible-sub-file new file: cmd/testdata/mtaignore/node-js/.invisible-dir/.invisible-sub-dir/visible-sub-file new file: cmd/testdata/mtaignore/node-js/.invisible-dir/visible-file new file: cmd/testdata/mtaignore/node-js/.invisible-dir/visible-sub-dir/.invisible-sub-file new file: cmd/testdata/mtaignore/node-js/.invisible-dir/visible-sub-dir/visible-sub-file modified: internal/artifacts/module_arch.go modified: internal/artifacts/mtar.go

modified: docs/docs/download.md modified: docs/docs/micromatch-wrapper.md modified: docs/docs/whatsnew.md

modified: docs/docs/download.md modified: docs/docs/whatsnew.md

young-yang03 · 2023-07-17T07:45:51Z

@ShiraManas, these days I added a new bool type attribute build-parameters ignore-use-full-glob-pattern to avoid regression. So there are some document update, and I recommit the PR and the new added docs are in commit: f3c1f60

ShiraManas · 2023-07-17T07:46:09Z

docs/docs/configuration.md

@@ -209,6 +209,7 @@ From the MBT 1.2.25 version, the `build-parameters ignore` attribute will be upg

 By using the negation pattern `!` in the `build-parameters ignore` attribute, you can select specified content into the package (because `not ignore` equals `include`).

+Notice, to avoid regression, a new bool type attribute `build-parameters ignore-use-full-glob-pattern` (default value is `false`) is added. Only when it is true, `build-parameters ignore` will support [full glob patterns](https://en.wikipedia.org/wiki/Glob_(programming)), otherwise MBT package behavior and result remain unchanged.


To avoid regression, a new bool type attribute, build-parameters ignore-use-full-glob-pattern (the default value is false), has been added. Only when it is set to true, build-parameters ignore will support full glob patterns. Otherwise the MBT package behavior and result remain unchanged.

Done, Thanks

ShiraManas · 2023-07-17T07:48:29Z

docs/docs/whatsnew.md

@@ -47,6 +47,8 @@ The `build-parameters ignore` attribute will be upgraded to support [full glob p

 By using the `!` negation pattern in the `build-parameters ignore` attribute, you can select specified content into the package (because `not ignore` equals `include`).

+Notice, to avoid regression, a new bool type attribute `build-parameters ignore-use-full-glob-pattern` (default value is `false`) is added. Only when it is true, `build-parameters ignore` will support [full glob patterns](https://en.wikipedia.org/wiki/Glob_(programming)), otherwise MBT package behavior and result remain unchanged.


To avoid regression, a new bool type attribute, build-parameters ignore-use-full-glob-pattern (the default value is false), has been added. Only when it is set to true, build-parameters ignore will support full glob patterns. Otherwise the MBT package behavior and result remain unchanged.

Done, Thanks

modified: docs/docs/whatsnew.md

Young Yang added 2 commits May 15, 2023 17:26

modified: internal/archive/fsops.go

1759aa7

young-yang03 requested a review from XinYe22 May 18, 2023 08:18

young-yang03 requested a review from ShimiT as a code owner May 18, 2023 08:18

Young Yang added 26 commits May 18, 2023 16:28

modified: internal/archive/fsops.go

e55f8a7

modified: cmd/testdata/mta/mta.yaml

449c51a

modified: internal/archive/fsops.go modified: micromatch/micromatch-wrapper.js modified: micromatch/test_micromatch_wrapper_bin.go modified: micromatch/test_micromatch_wrapper_js.go

modified: micromatch/micromatch-wrapper.js

f41f873

modified: micromatch/test_micromatch_wrapper_bin.go modified: micromatch/test_micromatch_wrapper_js.go

modified: internal/archive/fsops.go

62b41a8

modified: internal/archive/fsops.go

149060d

modified: internal/archive/fsops_test.go modified: micromatch/micromatch-wrapper.js modified: micromatch/test-micromatch.js modified: micromatch/test_micromatch_wrapper_js.go

modified: internal/archive/fsops_test.go

612167d

modified: micromatch/test-micromatch.js

new file: cmd/build_parameter_test.go

5ce5b74

modified: internal/archive/fsops.go modified: internal/archive/fsops_test.go new file: internal/archive/testdata/testproject/ui5app/webapp/view/.invisibleView

modified: Makefile

bba9ea4

modified: index.js

modified: cmd/build_parameter_test.go

2bda78a

modified: micromatch/Darwin/micromatch-wrapper modified: micromatch/Linux/micromatch-wrapper modified: micromatch/Windows/micromatch-wrapper.exe modified: package-lock.json

modified: Makefile

245dd37

modified: cmd/build_parameter_test.go modified: cmd/init_test.go modified: micromatch/Darwin/micromatch-wrapper modified: micromatch/Linux/micromatch-wrapper modified: micromatch/Windows/micromatch-wrapper.exe

modified: cmd/build_parameter_test.go

34981d4

modified: cmd/init_test.go

modified: .circleci/config.yml

a2c7e80

modified: cmd/build_parameter_test.go

modified: cmd/build_parameter_test.go

f673bf8

modified: cmd/build_parameter_test.go

db29514

modified: cmd/build_parameter_test.go

9703e2e

modified: .circleci/config.yml

7a19401

modified: cmd/build_parameter_test.go

7657366

modified: cmd/init_test.go

modified: .circleci/config.yml

29f92f3

modified: Dockerfile_mbtci_template modified: cmd/init_test.go

modified: Dockerfile_mbtci_template

5d998d5

modified: Makefile modified: test/goss/goss_template.yaml

modified: .circleci/config.yml

7015efe

modified: configs/builder_type_cfg.yaml

ShiraManas reviewed Jul 5, 2023

View reviewed changes

Young Yang added 2 commits July 5, 2023 21:42

modified: cmd/testdata/mta/mta.yaml

5e44988

modified: internal/artifacts/module_arch.go modified: internal/artifacts/mtar.go

modified: docs/docs/configuration.md

4897150

modified: docs/docs/download.md modified: docs/docs/micromatch-wrapper.md modified: docs/docs/whatsnew.md

ShiraManas reviewed Jul 10, 2023

View reviewed changes

Young Yang added 5 commits July 13, 2023 10:42

modified: micromatch/test-micromatch.js

2bd540d

modified: docs/docs/configuration.md

4297ce7

modified: docs/docs/download.md modified: docs/docs/micromatch-wrapper.md modified: docs/docs/whatsnew.md

modified: docs/docs/configuration.md

f3c1f60

modified: docs/docs/download.md modified: docs/docs/whatsnew.md

ShiraManas reviewed Jul 17, 2023

View reviewed changes

modified: docs/docs/configuration.md

d978026

modified: docs/docs/whatsnew.md


		- [Download](https://github.com/SAP/cloud-mta-build-tool/releases) the latest source code.

		- Install [pkg](https://github.com/vercel/pkg/) on your operating system


		* In Darwin, copy binary file `micromatch-wrapper` to the `~/usr/local/bin/` folder, for example: `cp micromatch-wrapper-macos /usr/local/bin/micromatch-wrapper`

		* In Linux, copy binary file `micromatch-wrapper` to the `~/usr/local/bin/` folder, for example: `cp micromatch-wrapper-linux /usr/local/bin/micromatch-wrapper`


		Install using npm

		Run the command below, it will install mbt and micromatch-wrapper together

		@@ -0,0 +1,52 @@
		#### Overview
		[Micromatch](https://github.com/micromatch/micromatch) support various matching features, such as glob patterns and advanced globbing

		@@ -209,6 +209,7 @@ From the MBT 1.2.25 version, the `build-parameters ignore` attribute will be upg

		By using the negation pattern `!` in the `build-parameters ignore` attribute, you can select specified content into the package (because `not ignore` equals `include`).

		Notice, to avoid regression, a new bool type attribute `build-parameters ignore-use-full-glob-pattern` (default value is `false`) is added. Only when it is true, `build-parameters ignore` will support [full glob patterns](https://en.wikipedia.org/wiki/Glob_(programming)), otherwise MBT package behavior and result remain unchanged.

		@@ -47,6 +47,8 @@ The `build-parameters ignore` attribute will be upgraded to support [full glob p

		By using the `!` negation pattern in the `build-parameters ignore` attribute, you can select specified content into the package (because `not ignore` equals `include`).

		Notice, to avoid regression, a new bool type attribute `build-parameters ignore-use-full-glob-pattern` (default value is `false`) is added. Only when it is true, `build-parameters ignore` will support [full glob patterns](https://en.wikipedia.org/wiki/Glob_(programming)), otherwise MBT package behavior and result remain unchanged.

MBT upgrade build parameter ignore attribute #1050

Are you sure you want to change the base?

MBT upgrade build parameter ignore attribute #1050

Conversation

young-yang03 commented May 18, 2023 • edited Loading

Description

Checklist

ShiraManas Jul 5, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ShiraManas Jul 5, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ShiraManas Jul 5, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ShiraManas Jul 5, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ShiraManas Jul 5, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ShiraManas left a comment

Choose a reason for hiding this comment

young-yang03 commented Jul 10, 2023

ShiraManas Jul 10, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ShiraManas left a comment

Choose a reason for hiding this comment

young-yang03 commented Jul 17, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ShiraManas Jul 17, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

young-yang03 commented May 18, 2023 •

edited

Loading

ShiraManas Jul 5, 2023 •

edited

Loading

ShiraManas Jul 5, 2023 •

edited

Loading

ShiraManas Jul 5, 2023 •

edited

Loading

ShiraManas Jul 5, 2023 •

edited

Loading

ShiraManas Jul 5, 2023 •

edited

Loading

ShiraManas Jul 10, 2023 •

edited

Loading

ShiraManas Jul 17, 2023 •

edited

Loading