Update configure-an-sap-fiori-for-the-abap-platform-job-in-the-job-editor-4c26bfb.md #5
Conversation
…itor-4c26bfb.md Changes to support adding Karma to a SAPUI5 Project.
|
|
|
Hi @longieirl! Thank you for your feedback! We’ll look into it and come back to you if we have any questions. |
|
|
||
| - Google Chrome installed, runnung headless Chrome is a way to run the Chrome browser in a headless environment without the full browser UI. |
There was a problem hiding this comment.
I am not sure if we need to mention this point here.
There was a problem hiding this comment.
I mentioned this since it wont run on BAS.
There was a problem hiding this comment.
In the sense that you would run it locally and in the CI/CD service, but not on BAS? That is why one should have Chrome installed locally?
There was a problem hiding this comment.
I get the point. However, in the CI/CD service documentation we usually only mention the prerequisites, which are needed to execute the test in the service and not in other SAP tools, like BAS. @SarahLendle : correct me if I'm wrong.
There was a problem hiding this comment.
@kaylinche should this comment be removed then? I only mentioned it in some cases, developers expect this all to work on any of the SAP tooling being provided to them.
| }, | ||
| singleRun: true, | ||
| proxies: { | ||
| '/base/webapp/resources': 'http://127.0.0.1:' + config.port + '/resources', |
There was a problem hiding this comment.
Is it necessary to add the proxy config for the minimal setup?
There was a problem hiding this comment.
Proxies are required as the app is starting up using the config of ui5.yaml or if the mock server is installed, using ui5-mock.yaml which spins up a local preview proxy to handle the URI routing and mocking of API requests.
| - In your repository, you have an SAPUI5/SAP Fiori project. See [Create an SAP Fiori Project](https://help.sap.com/viewer/9d1db9835307451daa8c930fbd9ab264/Cloud/en-US/46664de4d6944471b6c29a0681bfd0fc.html). | ||
|
|
||
|
|
||
| - In your repository, you have an SAPUI5/SAP Fiori project. See [Create an SAP Fiori Project](https://developers.sap.com/tutorials/appstudio-fioriapps-create.html). |
There was a problem hiding this comment.
did you test this app with cicd and did it work out of the box with the below mentioned config?
There was a problem hiding this comment.
The app settings was tested using a customers CI/CD job and using a SAP FIori tools app.
|
In general it looks good to me. @kaylinche @o-liver do you have any concerns? |
There was a problem hiding this comment.
Thanks @longieirl the updates look good.
I've added one suggestion.
docs/cicd/configure-an-sap-fiori-for-the-abap-platform-job-in-the-job-editor-4c26bfb.md
Outdated
Show resolved
Hide resolved
…the-job-editor-4c26bfb.md Co-authored-by: Austin Devine <devinea@users.noreply.github.com>
|
|
||
| - Google Chrome installed, runnung headless Chrome is a way to run the Chrome browser in a headless environment without the full browser UI. |
There was a problem hiding this comment.
In the sense that you would run it locally and in the CI/CD service, but not on BAS? That is why one should have Chrome installed locally?
docs/cicd/configure-an-sap-fiori-for-the-abap-platform-job-in-the-job-editor-4c26bfb.md
Outdated
Show resolved
Hide resolved
docs/cicd/configure-an-sap-fiori-for-the-abap-platform-job-in-the-job-editor-4c26bfb.md
Outdated
Show resolved
Hide resolved
…the-job-editor-4c26bfb.md Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
…the-job-editor-4c26bfb.md Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
docs/cicd/configure-an-sap-fiori-for-the-abap-platform-job-in-the-job-editor-4c26bfb.md
Outdated
Show resolved
Hide resolved
…the-job-editor-4c26bfb.md Co-authored-by: dimitrij-afonitschkin <131276293+dimitrij-afonitschkin@users.noreply.github.com>
|
Yes, I left out code coverage as its not required, once they have a working job they can easily introduce the coverage configuration. There are now links to the relevant karma sites that they can reference if this becomes a requirement. |
docs/cicd/configure-an-sap-fiori-for-the-abap-platform-job-in-the-job-editor-4c26bfb.md
Outdated
Show resolved
Hide resolved
…the-job-editor-4c26bfb.md Co-authored-by: Austin Devine <devinea@users.noreply.github.com>
SarahLendle
added
contribution
|
Thank you for your valuable content contribution, @longieirl! So that we can recognize your contribution in SAP Community, please tell us your SAP Community profile URL in a reply to this comment; don't include any other text, just the URL on its own, like this: Thanks! |
|
@longieirl As karma is deprecated, do you have any recommendation what could be used as an alternative test runner? |
Changes to support adding Karma to a SAPUI5 Project.