Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GetNamespaceInfo.ps1 to fix issue with private endpoints #1

Closed
wants to merge 1 commit into from

Conversation

jboeshart
Copy link

I was still seeing issues when trying to resolve names with private endpoints that was part of Azure#169. I think this addresses issues in both, and was the only way I was able to properly resolve all of the names properly.

This checklist is used to make sure that common guidelines for a pull request are followed.

  • I have read the contribution guidelines.
  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).
  • If applicable, the public code is properly documented.
  • Pull request includes test coverage for the included changes.
  • The code builds without any errors.

Fixing issue related to private endpoints
@jboeshart
Copy link
Author

Looks like Microsoft has updated their original script where it now handles the private endpoint resolution properly. This is no longer needed.

@jboeshart jboeshart closed this Oct 30, 2024
@jboeshart jboeshart deleted the patch-1 branch October 30, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant