Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Readme & fix up errors on pod lint #53

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

update Readme & fix up errors on pod lint #53

wants to merge 6 commits into from

Conversation

ShenYj
Copy link
Member

@ShenYj ShenYj commented Mar 24, 2022 •
edited
Loading

  • update Readme with target minimum version contains iOS 、watchOS and macOS
  • fix up on macOS and watchOS with the lint errors

@ShenYj ShenYj changed the title update Readme update Readme & fix up on macOS Mar 26, 2022
@ShenYj ShenYj requested a review from bobgodwinx March 26, 2022 03:58
ShenYj
ShenYj commented Mar 26, 2022
View reviewed changes
Copy link
Member Author

@ShenYj ShenYj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems like nobody use this framwork on macOS?

@ShenYj
[fix lint errors]update watchOS target minimum version to 4.0
0c8b113 
activityType and allowsBackgroundLocationUpdates can be used on 4.0
@ShenYj
Copy link
Member Author

ShenYj commented Mar 26, 2022

with these changes, RxCoreLocation passed validation by pod lib lint .....

@ShenYj ShenYj changed the title update Readme & fix up on macOS update Readme & fix up errors on pod lint Mar 26, 2022
@ShenYj
Copy link
Member Author

ShenYj commented Apr 8, 2023

it is so long without response

@ShenYj
Copy link
Member Author

ShenYj commented Apr 8, 2023

@bobgodwinx I've made some changes since your last confirmation, so I'll need your reconfirmation and permission

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobgodwinx bobgodwinx Awaiting requested review from bobgodwinx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShenYj @bobgodwinx