binding for SDL_FlashWindow added #1204
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrlcctrlv
suggested changes
Feb 7, 2022
| @@ -1768,6 +1768,17 @@ impl Window { | |||
| Ok(opacity) | |||
| } | |||
| } | |||
|
|
|||
| #[doc(alias = "SDL_FlashWindow")] | |||
| pub fn flash_window(&mut self, operation: sys::SDL_FlashOperation) -> Result<(), String> { | |||
There was a problem hiding this comment.
probably should just be called pub fn flash(…)
Cobrand
requested changes
Feb 7, 2022
There was a problem hiding this comment.
How did you generate sdl-bindings.rs? Using bindgen? This file is automatically generated, you cannot edit it manually.
You should create another enum FlashOperation in SDL2 which translates to sdl2_sys::SDL_FlashOperation . There are many examples of this in this repo, for instance MouseButton.
Use cargo fmt --check to make sure your code is fmt compliant. From one look I can tell that the else being on a separate line than its } will error the fmt check.
|
Okay thanks you, I will change that according to what you said . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I added bindings for
SDL_FlashWindowanswering to issue #1174 .A review would be very appreciated since it is my first contribution :).