-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fuselage-toastbar): Pause ToastBar timer while hovering #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2bc9b1d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dougfabris
requested changes
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Would be better to pause the interval while the user is hovering
- Since it changes the end user experience, it shouldn't be a
chore
debdutdeb
force-pushed
the
dont-close-toast-when-hovering
branch
from
June 25, 2024 06:43
abb2d8e
to
4329652
Compare
debdutdeb
changed the title
chore: don't close toast when hovering
feat: don't close toast when hovering
Jun 25, 2024
dougfabris
changed the title
feat: don't close toast when hovering
feat(fuselage-toastbar): Pause ToastBar timer when hovering
Jul 9, 2024
dougfabris
previously approved these changes
Jul 9, 2024
dougfabris
changed the title
feat(fuselage-toastbar): Pause ToastBar timer when hovering
feat(fuselage-toastbar): Pause ToastBar timer while hovering
Jul 9, 2024
dougfabris
previously approved these changes
Jul 9, 2024
dougfabris
previously approved these changes
Jul 9, 2024
tassoevan
requested changes
Jul 15, 2024
dougfabris
force-pushed
the
dont-close-toast-when-hovering
branch
from
July 18, 2024 14:38
da52ca4
to
25628b5
Compare
dougfabris
force-pushed
the
dont-close-toast-when-hovering
branch
from
July 18, 2024 14:43
25628b5
to
85fd8d4
Compare
tassoevan
approved these changes
Jul 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Further comments