Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fuselage): Contextualbar components size improvements #1366

Merged
merged 8 commits into from
Jun 13, 2024

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Apr 25, 2024

SIDE-21
SIDE-24
SIDE-74

Proposed changes (including videos or screenshots)

prev:
image
new:
image

Issue(s)

Further comments

Copy link

changeset-bot bot commented Apr 25, 2024

🦋 Changeset detected

Latest commit: dff42a0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rocket.chat/fuselage Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@juliajforesti juliajforesti marked this pull request as ready for review April 25, 2024 13:35
@dougfabris dougfabris changed the title feat(fuselage): new Contextualbar sizes feat(fuselage): ContextualBar component's size improvements Apr 25, 2024
@dougfabris dougfabris changed the title feat(fuselage): ContextualBar component's size improvements feat(fuselage): Contextualbar components size improvements Apr 25, 2024
dougfabris
dougfabris previously approved these changes Apr 25, 2024
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@juliajforesti juliajforesti changed the title feat(fuselage): Contextualbar components size improvements feat(fuselage): Contextualbar and Sidebar components size improvements Apr 25, 2024
@juliajforesti juliajforesti changed the title feat(fuselage): Contextualbar and Sidebar components size improvements feat(fuselage): Contextualbar components size improvements Apr 25, 2024
@dougfabris dougfabris merged commit 756430c into main Jun 13, 2024
6 checks passed
@dougfabris dougfabris deleted the feat/contextualbar-sizes branch June 13, 2024 17:41
@github-actions github-actions bot mentioned this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants