-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Waiting Queue
feature not queueing rooms
#33772
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: f28702f The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33772 +/- ##
========================================
Coverage 75.20% 75.20%
========================================
Files 495 495
Lines 21595 21595
Branches 5362 5362
========================================
Hits 16240 16240
Misses 4713 4713
Partials 642 642
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you think about starting with testing? then we can decide the best solution to fix
Waiting Queue
not workingWaiting Queue
feature not queueing rooms
Waiting Queue
feature not queueing roomsWaiting Queue
feature not queueing rooms
apps/meteor/tests/e2e/omnichannel/omnichannel-livechat-queue-management-autoselection.spec.ts
Show resolved
Hide resolved
apps/meteor/tests/e2e/omnichannel/omnichannel-livechat-queue-management-autoselection.spec.ts
Outdated
Show resolved
Hide resolved
0f1e34f
/patch |
after that just run |
/patch |
Pull request #34035 added to Project: "undefined" |
Proposed changes (including videos or screenshots)
getStatus
call, to return the chat as "queued" whenwaiting queue
is enabledbeforeRouteChat
callback to return an inquiry, and update caller to use the returned inq instead of finding it again.Issue(s)
https://rocketchat.atlassian.net/browse/SUP-663
Steps to test or reproduce
Further comments