Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made message box responsive and fixed alignment #664

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

abirc8010
Copy link
Contributor

@abirc8010 abirc8010 commented Nov 10, 2024

Brief Title

Made message box responsive and fixed alignment

Acceptance Criteria fulfillment

  • Set the min-width of the chat layout to 0 to improve responsiveness.
  • Updated the chat formatter tool to use display: grid for better layout handling on screens narrower than 383px.
  • Aligned the message box to the bottom by setting the chat body max-height to 100%.

Fixes # (issue)
#616 , #629

Video/Screenshots

message-box.webm

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-664 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@abirc8010
Copy link
Contributor Author

Hey @Spiral-Memory I closed the previous PR related to this and opened a new one with updated changes

@abirc8010
Copy link
Contributor Author

@Spiral-Memory is the layout for chat formatter tool ok for small screens ?

@Spiral-Memory
Copy link
Collaborator

@Spiral-Memory is the layout for chat formatter tool ok for small screens ?

For now, it's ok for me.. btw what changes are you proposing ?

@abirc8010
Copy link
Contributor Author

image

Currently the message box is not properly aligned to the bottom as it was reported in #616
This PR ensures that the message box is aligned to the bottom for any screen size

@abirc8010
Copy link
Contributor Author

image

Also for small screen sizes the message box is not completely visible
This PR fixes this UI responsiveness issue

@abirc8010
Copy link
Contributor Author

Hey @Spiral-Memory could you please check and review this PR whenever you are free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants