Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] :Share profile modal closes on submit #90

Closed
wants to merge 1 commit into from

Conversation

chinma-yyy
Copy link
Contributor

Issue(s)

closes #89

Acceptance Criteria fulfillment

  • Added submit button to the modal
  • Modal closing on submit

Proposed changes (including videos or screenshots)

Screencast.from.01-04-23.12.46.23.AM.IST.webm

Further comments

@chinma-yyy
Copy link
Contributor Author

Hey @samad-yar-khan I have created this pull request but I think the text formatting is done by prettier here. So can anyone help me with this formatting thing that led to changes in so many lines of code.

@samad-yar-khan
Copy link
Collaborator

@chinma-yyy , kind of hard to track relevant changes. Please update the PR.

@chinma-yyy
Copy link
Contributor Author

@chinma-yyy , kind of hard to track relevant changes. Please update the PR.

I am also unable to do the required changes I will instead create a new PR.

@chinma-yyy chinma-yyy closed this Apr 3, 2023
@chinma-yyy chinma-yyy reopened this Apr 3, 2023
@chinma-yyy chinma-yyy closed this Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile share modal not closing on submit
2 participants