Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Add Tracy Profiler #1407

Open
wants to merge 5 commits into
base: development
Choose a base branch
from
Open

Add Tracy Profiler #1407

wants to merge 5 commits into from

Conversation

mamiksik
Copy link
Contributor

Comments for the reviewer

Pre pull request checklist:

Code Quality
  • Is the code is understandable and easy to read
  • Changes to the code comply with set clang-format rules
  • No use of manual memory control (e.g new/malloc/colloc etc)
  • Are (only) smart pointers used?
Testing
  • All tests are passing.
  • I added new / changed existing tests to reflect code changes (state why not otherwise!)
  • I tested my changes manually (Describe how, to what extent etc.)
Commit Messages
  • Commit message is saying what has been changed, why it was changed? Remember other developers might not know
    what the problem you are fixing was. Note also negative decision (e.g., why did you not do particular thing)
    TLDR: Commit message are comprehensive
  • Commit messages follows the rules of https://chris.beams.io/posts/git-commit/

@mirixx mirixx self-assigned this Sep 19, 2022
The path to the header file was working
had to add a directory above it.
@mirixx mirixx removed their assignment Sep 19, 2022
Copy link
Member

@JAndringa JAndringa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, compiles runs and passes tests, but I'm missing some documentation on what this feature is for, how we use it and why it is implemented this way

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants