add rc_modified_memref_t #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates intermediate memref's for indirect memref references (AddAddress) and calculated values (AddSource/SubSource).
This ensures all memory reads happen when processing a frame (eliminates indirect evaluation when building rich presence string https://discord.com/channels/310192285306454017/1076603222489301002/1255132332508184596).
This also allows these intermediate values to be used by multiple achievements without having to recalculate them in each achievement (the logic will still be duplicated, but when converting to runtime logic, it will identify and reuse the existing intermediate memrefs).
Furthermore, to ease debugging, a natvis file has been added for the runtime structures.