Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resync asset list state after game assets list updated #1121

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

Jamiras
Copy link
Member

@Jamiras Jamiras commented Sep 9, 2024

Fixes an issue where assets deactivated by reloading the loaded game still appeared as active in the asset list.

Reloading the game would discarding any previously loaded assets and load local assets from the XXX-User.txt file in an inactive state. Then the asset list would update itself from the new asset list, but only adding or removing rows. Since the local asset already had a visible row, it was ignored, leaving the appearance of the asset still being active. Actually opening the asset in the asset editor would correctly reflect that the asset was inactive.

Solution: When updating the assets list after reloading the game, re-sync the assets that are neither removed or added to the list.

@Jamiras Jamiras added this to the 1.3.2 milestone Sep 9, 2024
@Jamiras Jamiras merged commit 40b527b into RetroAchievements:master Oct 10, 2024
6 checks passed
@Jamiras Jamiras deleted the bugfix/stale_assets branch October 10, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant