Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Pause button to memory bookmarks window #1116

Merged

Conversation

Jamiras
Copy link
Member

@Jamiras Jamiras commented Aug 17, 2024

To make it more obvious that the functionality even exists. I'm not really happy with the label, as it implies behavior very similar to freezing, but the button isn't large enough to fit the entire "Pause on Change" text, and it's consistent with the label shown in the column when the address is flagged to pause on change. "Pause on Change" would also be consistent with the "Pause on Reset" and "Pause on Trigger" options in the achievement editor.

image

@Jamiras Jamiras added this to the 1.3.1 milestone Aug 17, 2024
@wescopeland
Copy link
Member

wescopeland commented Aug 17, 2024

@Jamiras Is "Pause" kind of like setting a breakpoint with debugging tools? Maybe "Break" better conveys what it does. I'm not sure what the limitations of the UI are, but it may help to add an explanatory tooltip on the buttons (if one isn't already present).

I wonder if changing the "Freeze" label might also help, perhaps to something like "Lock"? Just to better differentiate the nuance between the two features.

@Jamiras
Copy link
Member Author

Jamiras commented Aug 17, 2024

Pause and Freeze are existing behaviors. Pause is currently only accessible by clicking on the field in the grid:
image

This is trying to make the feature more accessible to users. Most users don't even know you can click on the field in the grid. I originally didn't want to add more buttons to the bottom bar because I had plans to add several more things to the dropdown, but it's been several years now, and that still hasn't happened.

The freeze button has been present since the dialog was rewritten in 2020.

@Jamiras
Copy link
Member Author

Jamiras commented Aug 17, 2024

Is "Pause" kind of like setting a breakpoint with debugging tools? Maybe "Break" better conveys what it does.

Yes. It behaves like a debugger breakpoint. When the value changes, the emulator is paused, and a dialog pops up saying why.
image

My concerns against naming it "break" have to do with the userbase not being familiar with code debuggers. To a non-programmer, "break" usually means "make it not work". I asked for ideas in #devs-chat, and that came up there too, so it's the best alternative currently available.

@wescopeland
Copy link
Member

Got it. A few other alternatives I can think of:

  • "Halt on Chg"
  • "Monitor"

These are still a bit distinct from "Freeze", concise, and hopefully don't convey to non-programmers that we're breaking something.

No strong feelings on any of the alternatives, just want to add more ideas to the pool.

@Jamiras
Copy link
Member Author

Jamiras commented Aug 17, 2024

I discounted "Monitor" and "Watch" as that's the general behavior provided by the bookmarks window. I'd go with "Pause on Chg" over "Halt on Chg" for consistency, but I don't like arbitrarily removing letters to make text fit on a widget.

I think "Pause on Change" is different enough from "Freeze" that they wouldn't get confused with each other.

@redwizard42
Copy link
Contributor

redwizard42 commented Aug 17, 2024

Is it possible to just make the cell wider? (I forget the column header... Is it Behavior?)

Could have it do the default as
"Monitor Only"
With "Pause on Change" and "Freeze Value" as display updates for the existing options and make it a really explicit at the expense of making the horizontal real estate a bit wider by default

Having a non-blank default would make it more obvious you can do something with the cell too, though this statement isn't intended as opposition to a button to set behavior.

@Jamiras Jamiras merged commit d1786c0 into RetroAchievements:master Aug 27, 2024
6 checks passed
@Jamiras Jamiras deleted the feature/pause_bookmark_button branch August 27, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants