prevent assertion error reverting unpublished asset definition set to empty string #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://discord.com/channels/310192285306454017/533411674162593812/1273734162787860623
The attempt to upload was failing because the trigger definition was empty. As a result, the achievement was being reverted to the pre-upload state, which should have effectively been a no-op. But the modification to set the trigger to empty was not being reflected appropriately when the model was saved, so the revert left the model in a Modified state, which was unexpected and raised the exception.
Additionally, I've improved the error reporting when constructing API requests.