Add +/- shortcuts on the memory viewer #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhanced user experience by providing a way to increment or decrement a value with +/- directly in the memory view.
Jamiras
reviewed
Apr 26, 2024
- Add new HandleShortcut function to ControlBinding - Move logic to ViewModel - Fix Hungarian notation - Adjust Modifier defautl values to target low and high nibbles - Add unit tests
|
I commited the changes following that neat review ! Thanks @Jamiras ! |
Jamiras
reviewed
Apr 28, 2024
|
Commited ! Thanks ! |
|
CI checks have been fixed. |
Jamiras
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced user experience by providing a way to increment or decrement a value with +/- directly in the memory view.