Load all systems if there are no groups

RedHatInsights · Sep 13, 2023 · 39c2854 · 39c2854
1 parent f132755
commit 39c2854
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/ros/api/common/add_group_filter.py b/ros/api/common/add_group_filter.py
@@ -10,8 +10,6 @@ def group_filtered_query(query):
     if get_flag_value(FLAG_INVENTORY_GROUPS):
         if len(get_host_groups()) >= 1:
             query = query.filter(System.groups[0]['id'].astext.in_(get_host_groups()) | (System.groups == '[]'))
-        else:
-            query = query.filter((System.groups == '[]'))
     return query
 
 

diff --git a/tests/test_api_endpoints.py b/tests/test_api_endpoints.py
@@ -485,7 +485,7 @@ def test_systems_rbac_returns_emtpy_group(
         mock_rbac(get_rbac_mock_file("mock_rbac_returns_emtpy_group.json"), mocker)
         response = client.get('/api/ros/v1/systems', headers={"x-rh-identity": auth_token})
         assert response.status_code == 200
-        assert response.json["meta"]["count"] == 1
+        assert response.json["meta"]["count"] == 4
         assert response.json["data"][0]["groups"] == []
 
 
@@ -509,7 +509,7 @@ def test_systems_mock_rbac_returns_no_groups(
         mock_rbac(get_rbac_mock_file("mock_rbac_returns_no_groups.json"), mocker)
         response = client.get('/api/ros/v1/systems', headers={"x-rh-identity": auth_token})
         assert response.status_code == 200
-        assert response.json["meta"]["count"] == 1
+        assert response.json["meta"]["count"] == 4
 
 
 def test_systems_mock_rbac_returns_multiple_inventory_hosts_read(