Fixes #RHIROS-1269 - feature flags for backend

clowdapp.yaml

@@ -10,6 +10,7 @@ objects:
     name: ros-backend
   spec:
     envName: ${ENV_NAME}
+    featureFlags: true
     dependencies:
     - host-inventory
     - rbac
@@ -63,6 +64,17 @@ objects:
             value: ${DB_POOL_SIZE}
           - name: DB_MAX_OVERFLOW
             value: ${DB_MAX_OVERFLOW}
+          - name: UNLEASH_URL
+            value: ${UNLEASH_URL}
+          - name: UNLEASH_TOKEN
+            valueFrom:
+              secretKeyRef:
+                name: ${UNLEASH_SECRET_NAME}
+                key: CLIENT_ACCESS_TOKEN
+                optional: true
+          - name: BYPASS_UNLEASH
+            value: ${BYPASS_UNLEASH}
+
     - name: inventory-events-processor
       replicas: ${{INVENTORY_PROCESSOR_REPLICA_COUNT}}
       podSpec:
@@ -103,6 +115,17 @@ objects:
             value: ${DB_POOL_SIZE}
           - name: DB_MAX_OVERFLOW
             value: ${DB_MAX_OVERFLOW}
+          - name: UNLEASH_URL
+            value: ${UNLEASH_URL}
+          - name: UNLEASH_TOKEN
+            valueFrom:
+              secretKeyRef:
+                name: ${UNLEASH_SECRET_NAME}
+                key: CLIENT_ACCESS_TOKEN
+                optional: true
+          - name: BYPASS_UNLEASH
+            value: ${BYPASS_UNLEASH}
+
     - name: engine-result-processor
       replicas: ${{ENGINE_PROCESSOR_REPLICA_COUNT}}
       podSpec:
@@ -143,6 +166,17 @@ objects:
             value: ${DB_POOL_SIZE}
           - name: DB_MAX_OVERFLOW
             value: ${DB_MAX_OVERFLOW}
+          - name: UNLEASH_URL
+            value: ${UNLEASH_URL}
+          - name: UNLEASH_TOKEN
+            valueFrom:
+              secretKeyRef:
+                name: ${UNLEASH_SECRET_NAME}
+                key: CLIENT_ACCESS_TOKEN
+                optional: true
+          - name: BYPASS_UNLEASH
+            value: ${BYPASS_UNLEASH}
+
     - name: garbage-collector-processor
       replicas: ${{GARBAGE_COLLECTOR_REPLICA_COUNT}}
       podSpec:
@@ -187,6 +221,17 @@ objects:
             value: ${DB_POOL_SIZE}
           - name: DB_MAX_OVERFLOW
             value: ${DB_MAX_OVERFLOW}
+          - name: UNLEASH_URL
+            value: ${UNLEASH_URL}
+          - name: UNLEASH_TOKEN
+            valueFrom:
+              secretKeyRef:
+                name: ${UNLEASH_SECRET_NAME}
+                key: CLIENT_ACCESS_TOKEN
+                optional: true
+          - name: BYPASS_UNLEASH
+            value: ${BYPASS_UNLEASH}
+
     database:
       name: ros
       version: 13
@@ -305,3 +350,13 @@ parameters:
   value: "20"
 - name: DB_MAX_OVERFLOW
   value: "20"
+
+# Feature flags
+- description: Unleash secret name
+  name: UNLEASH_SECRET_NAME
+  value: bypass
+- description: Unleash API url
+  name: UNLEASH_URL
+- description: disable Unleash (feature flags), defaulting to fallback values
+  name: BYPASS_UNLEASH
+  value: 'false'

pyproject.toml

@@ -27,6 +27,7 @@ watchtower = ">=1.0.0"
 boto3 = ">=1.16.13"
 botocore = ">=1.19.13"
 flask-caching = "*"
+flask-unleash = "^2.0.0"
 
 [tool.poetry.group.dev.dependencies]
 flake8 = "*"

ros/api/common/add_group_filter.py

@@ -1,12 +1,24 @@
 from ros.lib.models import System
 from flask import request
+from ros.lib.feature_flags import FLAG_INVENTORY_GROUPS, get_flag_value
+from ros.lib.config import get_logger
+
+logger = get_logger(__name__)
 
 
 def group_filtered_query(query):
-    if hasattr(request, "host_groups"):
-        host_groups = [gid for gid in request.host_groups if gid is not None]
-        if len(host_groups) >= 1:
-            query = query.filter(System.groups[0]['id'].astext.in_(host_groups) | (System.groups == '[]'))
+    if get_flag_value(FLAG_INVENTORY_GROUPS):
+        if len(get_host_groups()) >= 1:
+            query = query.filter(System.groups[0]['id'].astext.in_(get_host_groups()) | (System.groups == '[]'))
         else:
             query = query.filter((System.groups == '[]'))
     return query
+
+
+def get_host_groups():
+    host_groups = []
+    try:
+        host_groups = [gid for gid in request.host_groups if gid is not None]
+    except AttributeError as e:
+        logger.debug(f"Can't parse the host groups, inventory groups feature is not available?: {e}")
+    return host_groups