Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: download egg as per the RHEL major version #4266

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xiangce
Copy link
Contributor

@xiangce xiangce commented Nov 8, 2024

  • Mulitple eggs will be provided on CDN for different RHEL releases
  • Decide the egg name before downloading according to the current RHEL major version
  • The orignial "insights-core.egg" is set as default
  • Jira Card: RHINENG-12166

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • No Sensitive Data in this change?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

- Mulitple eggs will be provided on CDN for different RHEL releases
- Decide the egg name before downloading according to the current
  RHEL major version
- The orignial "insights-core.egg" is set as default
- Jira Card: RHINENG-12166

Signed-off-by: Xiangce Liu <xiangceliu@redhat.com>
@xiangce xiangce marked this pull request as draft November 8, 2024 13:01
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.14%. Comparing base (b88a6e8) to head (cb097b1).

Files with missing lines Patch % Lines
insights/client/__init__.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4266      +/-   ##
==========================================
- Coverage   77.15%   77.14%   -0.01%     
==========================================
  Files         762      762              
  Lines       41510    41516       +6     
  Branches     8773     8773              
==========================================
+ Hits        32027    32029       +2     
- Misses       8426     8430       +4     
  Partials     1057     1057              
Flag Coverage Δ
unittests 77.13% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants