feat(floorist): add HMS FloorPlan export #2323
Conversation
|
Can one of the admins verify this patch? |
|
@romanblanco Hey Roman, can you please take a look if I used the v2 view correctly? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2323 +/- ##
=======================================
Coverage 98.79% 98.79%
=======================================
Files 237 237
Lines 5210 5210
=======================================
Hits 5147 5147
Misses 63 63 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Commit messages also need to be adjusted to match commitlint rules
shaded-enmity
force-pushed
the
add_hms_floorplan
branch
from
dd142cf
to
c124ae0
Compare
|
Thanks for the feedback @romanblanco can you please take another look? |
|
try |
romanblanco
changed the title
shaded-enmity
force-pushed
the
add_hms_floorplan
branch
from
dca04b4
to
2d60ab5
Compare
- Export timestamps, host_id and org_id of test_results - Add HMS secret Signed-off-by: Pavel Odvody <pavel@redhat.com>
shaded-enmity
force-pushed
the
add_hms_floorplan
branch
from
2d60ab5
to
b3aa66d
Compare
|
@romanblanco @vkrizan @skateman Thanks for the review folks! 🎉 All comments should be addressed. |
| @@ -657,6 +682,9 @@ parameters: | |||
| - description: database secret name | |||
| name: FLOORIST_DB_SECRET_NAME | |||
| value: compliance-db | |||
| - name: FLOORIST_HMS_BUCKET_SECRET_NAME | |||
There was a problem hiding this comment.
Don't forget to set up this variable and the secret in app-interface, prior to merging. Otherwise it would fail on stage and prod, and it would block floorist deployment automation. Thank you!
| - prefix: hms_analytics/compliance/tests | ||
| chunksize: 200000 | ||
| query: >- | ||
| SELECT |
There was a problem hiding this comment.
Can you also add ref_id from the canonical profile? This would enable us to track Compliance policies (stig, cisa, ...).
There was a problem hiding this comment.
@romanblanco @skateman Can you guys recommend how to get to this data, I see multiple ref_id's in the schema and have no idea which is the right one?
There was a problem hiding this comment.
@shaded-enmity, to get ref_id of the canonical profile[1], canonical_profiles[2] need to be joined on tailorings.profile_id[3].
[1]
compliance-backend/db/schema.rb
Line 286 in fc9709a
[2]
compliance-backend/db/schema.rb
Line 284 in fc9709a
[3]
compliance-backend/db/schema.rb
Line 311 in fc9709a
Secure Coding Practices Checklist GitHub Link
Secure Coding Checklist