Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(APIv2): RHINENG-14358 spec documentation #2318

Merged
merged 1 commit into from
Nov 25, 2024
Merged

docs(APIv2): RHINENG-14358 spec documentation #2318

merged 1 commit into from
Nov 25, 2024

Conversation

romanblanco
Copy link
Member

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@romanblanco romanblanco requested a review from a team as a code owner November 22, 2024 16:25
@romanblanco romanblanco marked this pull request as draft November 22, 2024 16:25
CodeDuchess
CodeDuchess reviewed Nov 22, 2024
View reviewed changes
Copy link

@CodeDuchess CodeDuchess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@romanblanco Hey Roman. I have a few suggestions. Otherwise it looks great!

spec/integration/v2/rules_spec.rb Outdated Show resolved Hide resolved
swagger/v2/openapi.json Outdated Show resolved Hide resolved
swagger/v2/openapi.json Outdated Show resolved Hide resolved
swagger/v2/openapi.json Outdated Show resolved Hide resolved
romanblanco
romanblanco commented Nov 22, 2024
View reviewed changes
Copy link
Member Author

@romanblanco romanblanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CodeDuchess Applied other set of suggestions.

spec/integration/v2/policies_spec.rb Outdated Show resolved Hide resolved
spec/integration/v2/systems_spec.rb Outdated Show resolved Hide resolved
spec/integration/v2/systems_spec.rb Outdated Show resolved Hide resolved
spec/integration/v2/rules_spec.rb Outdated Show resolved Hide resolved
spec/integration/v2/rules_spec.rb Outdated Show resolved Hide resolved
spec/integration/v2/rules_spec.rb Outdated Show resolved Hide resolved
spec/integration/v2/security_guides_spec.rb Outdated Show resolved Hide resolved
spec/integration/v2/supported_profiles_spec.rb Outdated Show resolved Hide resolved
spec/integration/v2/value_definitions_spec.rb Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Nov 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.78%. Comparing base (c6e5dc7) to head (3449083).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2318   +/-   ##
=======================================
  Coverage   98.78%   98.78%           
=======================================
  Files         237      237           
  Lines        5206     5206           
=======================================
  Hits         5143     5143           
  Misses         63       63

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@romanblanco romanblanco force-pushed the RHINENG-14358-api-spec-docs branch 2 times, most recently from a02219a to 1f6f906 Compare November 22, 2024 20:55
@romanblanco romanblanco force-pushed the RHINENG-14358-api-spec-docs branch 4 times, most recently from 7cbd3d4 to ca841bc Compare November 22, 2024 22:16
@romanblanco romanblanco marked this pull request as ready for review November 22, 2024 22:16
@romanblanco romanblanco force-pushed the RHINENG-14358-api-spec-docs branch 2 times, most recently from d21f234 to bfc0236 Compare November 23, 2024 09:33
@romanblanco romanblanco merged commit 19e1f23 into RedHatInsights:master Nov 25, 2024
13 checks passed
@romanblanco romanblanco deleted the RHINENG-14358-api-spec-docs branch November 25, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeDuchess CodeDuchess Awaiting requested review from CodeDuchess

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romanblanco @CodeDuchess