Skip to content

Commit

Permalink
Merge pull request #1037 from gburges/params
Browse files Browse the repository at this point in the history
feat: Need to define parameters STRIMZI_USE_FINALIZERS too
  • Loading branch information
psav authored Aug 30, 2024
2 parents ae50501 + 44d0356 commit 288b91a
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 1 deletion.
2 changes: 2 additions & 0 deletions deploy-mutate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8758,4 +8758,6 @@ parameters:
value: quay.io/cloudservices/minio:RELEASE.2020-11-19T23-48-16Z-amd64
- name: FEATUREFLAGS_IMAGE
value: quay.io/cloudservices/unleash-docker:5.6.9
- name: STRIMZI_USE_FINALIZERS
value: 'true'

2 changes: 2 additions & 0 deletions deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8731,4 +8731,6 @@ parameters:
value: quay.io/cloudservices/minio:RELEASE.2020-11-19T23-48-16Z-amd64
- name: FEATUREFLAGS_IMAGE
value: quay.io/cloudservices/unleash-docker:5.6.9
- name: STRIMZI_USE_FINALIZERS
value: 'true'

2 changes: 1 addition & 1 deletion docs/api_ref.md
Original file line number Diff line number Diff line change
Expand Up @@ -1188,4 +1188,4 @@ Must be one of:
**Description:** The external hostname of the deployment, where applicable

----------------------------------------------------------------------------------------------------------------------------
Generated using [json-schema-for-humans](https://github.com/coveooss/json-schema-for-humans) on 2024-08-28 at 14:57:43 +0200
Generated using [json-schema-for-humans](https://github.com/coveooss/json-schema-for-humans) on 2024-08-30 at 12:53:42 +0200
1 change: 1 addition & 0 deletions docs/api_reference.md
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,7 @@ _Appears in:_
| `jobs` _string array_ | Jobs is the set of jobs to be run by the invocation |
| `testing` _[JobTestingSpec](#jobtestingspec)_ | Testing is the struct for building out test jobs (iqe, etc) in a CJI |
| `runOnNotReady` _boolean_ | RunOnNotReady is a flag that when true, the job will not wait for the deployment to be ready to run |
| `disabled` _boolean_ | Disabled is a flag to turn off CJI(s) from running |



Expand Down
2 changes: 2 additions & 0 deletions template.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,6 @@ parameters:
value: "quay.io/cloudservices/minio:RELEASE.2020-11-19T23-48-16Z-amd64"
- name: FEATUREFLAGS_IMAGE
value: "quay.io/cloudservices/unleash-docker:5.6.9"
- name: STRIMZI_USE_FINALIZERS
value: "true"
objects: []

0 comments on commit 288b91a

Please sign in to comment.