-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - Cathub kinetics #499
Open
davidfarinajr
wants to merge
11
commits into
main
Choose a base branch
from
cathub
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Oct 24, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 86bd818 - Browse repository at this point
Copy the full SHA 86bd818View commit details -
added cathub Pt kinetics library
only with Eas, As are None
Configuration menu - View commit details
-
Copy full SHA for cefc7b0 - Browse repository at this point
Copy the full SHA cefc7b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for cbdfad6 - Browse repository at this point
Copy the full SHA cbdfad6View commit details -
Configuration menu - View commit details
-
Copy full SHA for b0f5ab1 - Browse repository at this point
Copy the full SHA b0f5ab1View commit details -
Configuration menu - View commit details
-
Copy full SHA for f1249cb - Browse repository at this point
Copy the full SHA f1249cbView commit details -
these are reactions which currently dont match any of our families
Configuration menu - View commit details
-
Copy full SHA for 8446261 - Browse repository at this point
Copy the full SHA 8446261View commit details -
Configuration menu - View commit details
-
Copy full SHA for 12b6e1c - Browse repository at this point
Copy the full SHA 12b6e1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c2f197 - Browse repository at this point
Copy the full SHA 0c2f197View commit details -
Configuration menu - View commit details
-
Copy full SHA for 035cda3 - Browse repository at this point
Copy the full SHA 035cda3View commit details -
MultiArr -> Arr for cathub reactions
The duplicate cathub reactions were converted to MultiArrh. However, we do not want to add these rates together, so I converted them to SurfaceArrhenius and selected the more recent calculation (SchumannSelectivity2018)
Configuration menu - View commit details
-
Copy full SHA for 7d91ee8 - Browse repository at this point
Copy the full SHA 7d91ee8View commit details -
removed metal and facet from surface thermo group entries
Since we now consider metal attrs when descending the tree, these need to be removed from thermo group entries
Configuration menu - View commit details
-
Copy full SHA for 25d5b34 - Browse repository at this point
Copy the full SHA 25d5b34View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.