adapt preprocessor defines for result_of/invoke_result #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddelbuettel
approved these changes
Jan 12, 2024
|
Oh sorry, spotted some missing defines. Updating shortly. |
|
Hi @tnagler we managed to get 3.4.0 in, at last! How do you about maybe rebasing and seeing if this would fit now? |
|
Oh that's great! After updating to Eigen 3.4.0, this PR should be redundant, because I simply stripped the relevant parts from the 3.4.0 Macros.h and Meta.h. I'll close for now and check these days, whether everything works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding #123: I don't really have the capacity to work on the Eigen 3.4.0 update, but I thought adapting the relevant parts (1, 2, 3) of the preprocessor logic could be an easy fix to make the warnings disappear (and ensure RcppEigen compiles with C++20)?