Fix Thunderbolt crashing clients when owner is invalid #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
needs testing
Alystrasz
approved these changes
Nov 24, 2024
Zanieon
added
READY TO MERGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried several approaches in several test sessions with @Alystrasz to see how i could finally fix this issue, unfortunately this is the only one that prevented this screen from happening:
This also fixes NPCs doing this exact same crash if they fire a Thunderbolt and are killed right after.
The problem in here is not a validity check in the attacker, that check is actually passing when i tested, what is causing the crash is the
GetParent()function and i cannot simply remove that because it's the check responsible to tell when an attack was done from rodeo (i.e battery pulls, classic rodeo riff).