Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add crosshair target changed callback #893

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Add crosshair target changed callback #893

wants to merge 12 commits into from

Conversation

NachosChipeados
Copy link
Contributor

Adds a callback that triggers whenever you hover your crosshair over any entity. Adds 2 vanilla files.

Warning: loud
https://github.com/user-attachments/assets/6ff30761-63ed-47ed-a25b-586a29a76eee

Script used: 
untyped

global function crosshaircallback_Init

void function crosshaircallback_Init()
{
	AddCallback_OnCrosshairCurrentTargetChanged ( wow )
}

void function wow ( entity player, entity newTarget )
{
	printt ( "guh" )

	EmitSoundOnEntity( player, "Pilot_Killed_Indicator" )
}

@github-actions github-actions bot added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Oct 13, 2024
@Zanieon Zanieon added the commits vanilla file For PRs that commit vanilla files from VPKs label Oct 13, 2024
JMM889901
JMM889901 reviewed Oct 14, 2024
View reviewed changes
Copy link
Contributor

@JMM889901 JMM889901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems fine. cannot test atm
actual diff is: https://github.com/R2Northstar/NorthstarMods/pull/893/files/9a73ace1a1e5273fda96be7f8b643489295e3940..eaf586c384d3968e62cb802f7eee4516fe689386

@GeckoEidechse GeckoEidechse self-assigned this Nov 15, 2024
@github-actions github-actions bot added the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Nov 16, 2024
GeckoEidechse
GeckoEidechse reviewed Nov 16, 2024
View reviewed changes
Northstar.Client/mod/scripts/vscripts/client/cl_sp_player.gnut
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From which VPK is that vanilla file from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its in all sp vpks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, so ig it's the same in all of them? I'll check ig and then add it from one of them ^^

@github-actions github-actions bot removed the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JMM889901 JMM889901 JMM889901 left review comments

@GeckoEidechse GeckoEidechse GeckoEidechse left review comments

@Zanieon Zanieon Zanieon left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@GeckoEidechse GeckoEidechse

Labels
commits vanilla file For PRs that commit vanilla files from VPKs needs code review Changes from PR still need to be reviewed in code needs testing Changes from the PR still need to be tested
Projects
Northstar Roadmap
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NachosChipeados @Zanieon @GeckoEidechse @JMM889901