-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow executing npc_pilot_elite
NPCs
#888
Allow executing npc_pilot_elite
NPCs
#888
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect the PR has side effects.
Without PR
pr_main.webm
With PR
pr_with_main.webm
I haven't been able to recreate that in my end, so i'm not sure why it happens. Will investigate though Titanfall.2.2024-10-06.18-12-31.mp4 |
Yeah, i've got nothing. This pr doesn't modify their models or animations in any way, and i can't even repoduce the bug locally so i genuinely have no idea what's going on there |
Update: while testing a completely unrelated pr, i managed to recreate the pilot elite bug, so i can confirm that it is unrelated to this pr and seems to be a bug with the vanilla game itself. I didn't even have this pr enabled while doing this, as you can see by the lack of exectuon prompt and headshot fx Titanfall.2.2024-10-18.12-19-04.mp4 |
I could reproduce the issue on another computer, with a fresh Titanfall2 + Northstar install. |
Check #development in the discord |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out behavior bugs are not introduced by this PR (see R2NorthstarTools/FlightCore#1038 for more details).
I confirm this PR allows to execute npc_pilot_elite
NPCs.
npc_pilot_elite-execution.webm
Merging based on reviews. Sorry it took so long ^^" |
Allows players to execute pilot NPCs. Since every mod that uses
npc_pilot_elite
NPCs for something (see Gruntmode) , also adds similar changes to this, i think it'd be nice to bring this change into Northstar officially.Before:
https://github.com/user-attachments/assets/489cc6f1-bc9f-4254-88a5-c30c7e30f6d6
After:
https://github.com/user-attachments/assets/b1263242-c6e8-403d-941c-8bed822ef5cc
Also added missing gib + headshot fx, to prevent weirdness.
Before:
https://github.com/user-attachments/assets/d8874ab2-fdeb-48eb-9db8-10526770f717
After:
https://github.com/user-attachments/assets/33eca4fd-3ec4-49a7-805a-024093efd068
HOW TO TEST:
ent_create npc_pilot_elite
)Know issues:
https://github.com/user-attachments/assets/68375bb5-29ed-4f59-b5fb-a5eb0a0fcc44