-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Server-side choice RUI #831
Draft
Alystrasz
wants to merge
22
commits into
R2Northstar:main
Choose a base branch
from
Alystrasz:feat/serverside-choice
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
ce1c984
feat: add NSCreateChoiceOnPlayer server-side function
Alystrasz c16037f
feat: send choice parameters to client
Alystrasz 749d200
feat: use RUI component to display choice on client
Alystrasz 51fbb68
feat: emit sound on choice UI spawn
Alystrasz fd06f34
feat: RUI disappears with a smooth transition
Alystrasz e5454d4
fix: multiple choices can be triggered one after another
Alystrasz 07f519e
feat: player can answer choice prompts
Alystrasz f50ed89
feat: add NSGetPlayerChoiceResponse method
Alystrasz ee9d35b
refactor: NSGetPlayerChoiceResponse returns -2 if input player is not…
Alystrasz 6787f28
refactor: integrate key to choice API
Alystrasz e19cb6c
feat: add NSCreateChoiceOnAllPlayers util function
Alystrasz 06de4be
Merge branch 'main' into feat/serverside-choice
Zanieon 6325524
Merge branch 'main' into feat/serverside-choice
Alystrasz 7a8b711
refactor: API takes an array of strings as input parameter
Alystrasz 18ec783
feat: NSCreateChoiceOnPlayer throws when not getting 1 or 2 options
Alystrasz d4525b8
Merge branch 'main' into feat/serverside-choice
Alystrasz 39cacda
refactor: add ePlayerChoiceStatus enum
Alystrasz 7030714
Merge branch 'main' into feat/serverside-choice
Alystrasz 71a79f2
style: use spaces to align enum (instead of tabs)
Alystrasz 8141ccd
feat: support one choice only
Alystrasz f7909ec
Merge branch 'main' into feat/serverside-choice
Alystrasz a3c55f7
Merge branch 'main' into feat/serverside-choice
Alystrasz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scriptCommand1
/scriptCommand2
feel like placeholder names :P