Fix memory leak and (kinda) cleanup code? #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASpoonPlaysGames
added
needs testing
|
Considering we want to nuke AUTOHOOK is there any use in potentially breaking it just for it to look slightly nicer? |
|
Tried testing on Linux but it failed to launch and in the process my Wine prefix got polluted to the point where EA would crash. I'm not sure if this is a Linux skill issue or an effect of this PR. Either way, if someone could test this on Windows in the meantime to LMK whether it works or not, that'd be great <3 |
|
@RoyalBlue1 said she agrees with @F1F7Y on this. |
NachosChipeados
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To try and preserve behaviour I used
do whilewhich I don't think ended up making the code much more readable... ah well, fixed a memory leak at least.Testing: