Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ns_startup_args*.txt functionality #517

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

F1F7Y
Copy link
Member

@F1F7Y F1F7Y commented Jul 26, 2023

Removes ns_startup_args*.txt functionality as discussed at #507

Main reason for doing this is getting rid of having to hook GetCommandLineA, which meant some args would only work when passed directly to the exe.

@F1F7Y F1F7Y added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Jul 27, 2023
{
std::ofstream file("ns_startup_args.txt");
std::string defaultArgs = "-multiple";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR means we lose the functionality of these default args right?

If so, this could cause issues with the game complaining about multiple instances if an instance is stuck in the background or something

{
std::ofstream file("ns_startup_args_dedi.txt");
std::string defaultArgs = "+setplaylist private_match";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the behaviour for dedis when this functionality is lost?

Also, a number of dedis use ns_startup_args_dedi.txt to set up the server. If this gets merged we should warn server hosters about this no longer being supported

@github-actions github-actions bot added the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Dec 27, 2023
@GeckoEidechse
Copy link
Member

Merge conflicts atm
(hence we should go with compile time feature flag first cause it's less likely to cause merge conflicts and allows for easy revert if need be. Once we determined that we can fully deprecate the feature, by forcing everyone onto a version that no longer has it, we can fully remove it together with the parsing logic)

@GeckoEidechse GeckoEidechse marked this pull request as draft August 19, 2024 15:25
@GeckoEidechse
Copy link
Member

Drafted until conflicts are resolved so it's clear which PRs are ready to review atm. Feel free to undraft again at any moment or when you resolved the conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge conflicts Blocked by merge conflicts, waiting on the author to resolve needs code review Changes from PR still need to be reviewed in code needs testing Changes from the PR still need to be tested
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants