-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ns_startup_args*.txt
functionality
#517
base: main
Are you sure you want to change the base?
Remove ns_startup_args*.txt
functionality
#517
Conversation
{ | ||
std::ofstream file("ns_startup_args.txt"); | ||
std::string defaultArgs = "-multiple"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR means we lose the functionality of these default args right?
If so, this could cause issues with the game complaining about multiple instances if an instance is stuck in the background or something
{ | ||
std::ofstream file("ns_startup_args_dedi.txt"); | ||
std::string defaultArgs = "+setplaylist private_match"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the behaviour for dedis when this functionality is lost?
Also, a number of dedis use ns_startup_args_dedi.txt
to set up the server. If this gets merged we should warn server hosters about this no longer being supported
Merge conflicts atm |
Drafted until conflicts are resolved so it's clear which PRs are ready to review atm. Feel free to undraft again at any moment or when you resolved the conflicts. |
Removes
ns_startup_args*.txt
functionality as discussed at #507Main reason for doing this is getting rid of having to hook
GetCommandLineA
, which meant some args would only work when passed directly to the exe.