-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor sq api init #461
base: main
Are you sure you want to change the base?
refactor sq api init #461
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works in testing, plugins still work too.
refactoring good :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing this until I have time to look at it more closely.
- Need to check each refactored line.
- If the UB depends on the layout of TF stuff, it's fine, but if it's on our own classes, it's not worth it.
*bump* |
@uniboi just a heads-up that this PR has some merge conflicts atm |
merge conflicts still |
Converting to draft until merge conflicts are addressed. cc @uniboi |
Makes initializing the SquirrelManagers more readable by having definitions for CLIENT, UI & SERVER vm in one place.
Currently it looks like this
The redundancy is annoying and makes it hard to see at a glance what the offsets for the functions are.
This PR implements this function that initializes the functions either on the
CLIENT
&UI
or on theSERVER
dynamically:Initializing a function for all vms now looks like this:
The issue with this is that the memory layout of classes is ub afaik