Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numpy dependency #19

Closed
wants to merge 2 commits into from
Closed

Conversation

zevaryx
Copy link

@zevaryx zevaryx commented Aug 22, 2024

Numpy 2.0 breaks Factorio-SAT

Numpy 2.0 breaks Factorio-SAT
No hard locking, just numpy<2
@zevaryx zevaryx changed the title Lock numpy to 1.26.4 Fix numpy dependency Aug 22, 2024
@zatricky
Copy link
Contributor

What does 2.0 break? It might make sense to do this temporarily - but it might be more practical instead to update Factorio-SAT to use numpy v2 properly.

@R-O-C-K-E-T
Copy link
Owner

I think I've fixed the incompatibility with numpy 2.0 in d26eea6.
For now I'm closing this pull request, if there are any other issues with 2.0 that I've missed feel free to raise an issue for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants