Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase time limit grid search example #68

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

FrancescMartiEscofetQC
Copy link
Contributor

@FrancescMartiEscofetQC FrancescMartiEscofetQC commented Jul 23, 2024

In some commits readthedocs failed, see here or here. In both cases pushing an empty commit to trigger rebuilding the docs solved it. We can't check the reason why it failed because it's dumped on a file but as it is not a consistent failure my hypothesis is that it is due to reaching the maximum execution time. This PR increases the timeout for the grid search example which is the one that failed.

PD: I opened an issue to be able to show the traceback in case the execution of a notebook fails. If that is fixed we could set nb_execution_show_tb = True in conf.py and we would see the error on the output of ReadtheDocs.

Checklist

  • Added a CHANGELOG.rst entry

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.88%. Comparing base (851c1ca) to head (3745318).
Report is 21 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #68   +/-   ##
=======================================
  Coverage   94.88%   94.88%           
=======================================
  Files          15       15           
  Lines        1544     1544           
=======================================
  Hits         1465     1465           
  Misses         79       79           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@kklein kklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@FrancescMartiEscofetQC FrancescMartiEscofetQC marked this pull request as ready for review July 23, 2024 07:29
@FrancescMartiEscofetQC FrancescMartiEscofetQC merged commit 5c8e467 into main Jul 23, 2024
16 checks passed
@FrancescMartiEscofetQC FrancescMartiEscofetQC deleted the gridsearch_example_time_limit branch July 23, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants