Update imp to importlib for py3 #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
python36/37 are failing for some tests which may have to do with the |
jccurtis
commented
Sep 16, 2020
| if sys.version_info >= (3, 6): | ||
| import importlib as imp | ||
| else: | ||
| import imp | ||
| imp.reload(imp) |
There was a problem hiding this comment.
I wonder if this is causing the CI failure.
|
According to docs, the module has been deprecated since 3.4 with certain methods deprecated since 3.3. Looking at specific methods such as https://docs.python.org/3/library/imp.html#imp.find_module, you might not be able to do a blanket alias and have to do specific imports. |
32 tasks
5 tasks
28 tasks
|
Thanks @jccurtis ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
impwas deprecated in py36. While this package is not needed in most py3 packages after Jan2020, there still are some which maintain py27 support and thisDeprecationWarningpops up. I think I covered all cases in the src tree. There are 2 (AFAIK) locations elsewhere (examples and docs) that usefrom imp import reload. I did not patch these.Closes #488