Trivial code cleanup #448
Trivial code cleanup #448
Conversation
This is mostly stuff picked up by `ruff check --fix` with some extra fixes to the type checking.
| @@ -349,7 +349,7 @@ def write_soon(self, data): | |||
| raise ClientDisconnected | |||
| num_bytes = len(data) | |||
|
|
|||
| if data.__class__ is ReadOnlyFileBasedBuffer: | |||
| if isinstance(data, ReadOnlyFileBasedBuffer): | |||
There was a problem hiding this comment.
There was a reason this was a data.__class__ check instead of isinstance, and something broke in the past when I tried to update this. I just can't remember what exactly.
There was a problem hiding this comment.
I wasn't able to find anything in the history. That line goes back well over a decade, and Chris didn't leave any explanation of why it uses .__class__ is ... rather than isinstance(...). I can revert the code to use the former and instead leave a "there be dragons" comment here and in task.py, if that works?
There was a problem hiding this comment.
It was probably me avoiding a funccall for performance reasons while I was doing profiling.
There was a problem hiding this comment.
I'm a big fan of "if tests pass..." so let's let it ride for now.
I will re-review this tomorrow when I am not sleep deprived, and hope that I can remember what the issue was.
This is mostly stuff picked up by
ruff check --fixwith some extra fixes to the type checking.A few assertion clean-ups leaked across from #447, but I don't think that's too big a deal.