-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pre-commit 4.0.0: InvalidManifestError #289
Comments
Update pre-commit hooks to the latest versions and limit the pre-commit version to <4.0.0 because of <PyCQA/docformatter#289>.
Update pre-commit hooks to the latest versions and limit the pre-commit version to <4.0.0 because of <PyCQA/docformatter#289>.
* docformatter breaks pre-commit on version 4.0. Need to pin this until this issue is resolved: PyCQA/docformatter#289 * in future when this is resolved also need to run `pre-commit migrate-config`
Update pre-commit hooks to the latest versions and limit the pre-commit version to <4.0.0 because of <PyCQA/docformatter#289>.
Update pre-commit hooks to the latest versions and limit the pre-commit version to <4.0.0 because of <PyCQA/docformatter#289>.
Update pre-commit hooks to the latest versions and limit the pre-commit version to <4.0.0 because of <PyCQA/docformatter#289>.
Update pre-commit hooks to the latest versions and limit the pre-commit version to <4.0.0 because of <PyCQA/docformatter#289>.
@asottile is |
please don't mention me when you can read the docs it has been a warning and alias for years |
Update pre-commit hooks to the latest versions and limit the pre-commit version to <4.0.0 because of <PyCQA/docformatter#289>.
- PyCQA/docformatter#289 - PyCQA/docformatter#287 Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
- PyCQA/docformatter#289 - PyCQA/docformatter#287 Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
* Begin improvement of refs generation Signed-off-by: Fabrice Normandin <normandf@mila.quebec> * Proof of concept works! Converts backtics to refs Signed-off-by: Fabrice Normandin <normandf@mila.quebec> * Simplify, trim stuff Signed-off-by: Fabrice Normandin <normandf@mila.quebec> * Add a test for the autoref plugin Signed-off-by: Fabrice Normandin <normandf@mila.quebec> * Remove unused code paths Signed-off-by: Fabrice Normandin <normandf@mila.quebec> * Update pre-commit config? Signed-off-by: Fabrice Normandin <normandf@mila.quebec> * Try a fix for broken docformatter pre-commit hook - PyCQA/docformatter#289 - PyCQA/docformatter#287 Signed-off-by: Fabrice Normandin <normandf@mila.quebec> * Restrict pre-commit version for now Trying the same approach as DSD-DBS/capella-dockerimages@6e38a0c Signed-off-by: Fabrice Normandin <normandf@mila.quebec> * Temporarily don't use existing regression files There's this issue at the moment with some reproducibility test that cause the CI to fail. I'll make another PR to address this, but for now, I'm turning off the 'shared regression files in $SCRATCH' feature. Signed-off-by: Fabrice Normandin <normandf@mila.quebec> * Add test to reach 100% patch coverage Signed-off-by: Fabrice Normandin <normandf@mila.quebec> --------- Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
Fixed in PR #290. |
This is necessary since it uses outdated config format for pre-commit. Refs: * PyCQA/docformatter#287 * PyCQA/docformatter#289
For anyone who still has this issue. - repo: https://github.com/PyCQA/docformatter
rev: 06907d0
hooks:
- id: docformatter
additional_dependencies: [tomli]
args: [--in-place, --config, ./pyproject.toml] |
Does this work? I remember some tooling only allowing full commit hashes and being unhappy about the short ones. |
- PyCQA/docformatter#289 - PyCQA/docformatter#287 Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
It may be fixed in the default branch, but there isn't a release available with the fix yet. |
Yes, @webknjaz. |
* Add test to reproduce issue Signed-off-by: Fabrice Normandin <normandf@mila.quebec> * Bugfix for mila code in WSL Signed-off-by: Fabrice Normandin <normandf@mila.quebec> * Fix issue in pre-commit hook - PyCQA/docformatter#289 - PyCQA/docformatter#287 Signed-off-by: Fabrice Normandin <normandf@mila.quebec> * Remove unnecessary mock for RemoteV2 in test Signed-off-by: Fabrice Normandin <normandf@mila.quebec> * Remove unnecessary xfail mark on Windows Signed-off-by: Fabrice Normandin <normandf@mila.quebec> * Adjust the regression test files following changes Signed-off-by: Fabrice Normandin <normandf@mila.quebec> * Add xfail for flaky integration test Signed-off-by: Fabrice Normandin <normandf@mila.quebec> --------- Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
This PR sets ubuntu version to 22.04 for scripts run with python 3.7. Reference: [ADDON-75861](https://splunk.atlassian.net/browse/ADDON-75861) Python version for pre-commit can not be updated to latest version due to open issue with the docformatter hook. Reference: PyCQA/docformatter#289, PyCQA/docformatter#293
I can confirm this works. |
My
.pre-commit-config.yaml
includes the following:Error:
The problematic line of YAML can be found here:
docformatter/.pre-commit-hooks.yaml
Line 13 in 886a032
Possible solution:
Fix hook
The text was updated successfully, but these errors were encountered: