Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More Stuff #22

Open
wants to merge 56 commits into
base: main
Choose a base branch
from
Open

More Stuff #22

wants to merge 56 commits into from

Conversation

LeontKing2
Copy link

No description provided.

@LeontKing2
Copy link
Author

the index.php file is from https://github.com/Jiaocz/Blank-Rick-Roll/blob/PHP-version/index.php credits to @Jiaocz

LeontKing2
LeontKing2 commented Sep 21, 2021
View reviewed changes
Copy link
Author

@LeontKing2 LeontKing2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D

Jiaocz
Jiaocz reviewed Sep 21, 2021
View reviewed changes
Copy link

@Jiaocz Jiaocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool stuff! 😎
But there is a mistake in file readme.md: line 11 miss a space after "1." making that section not being recognized as a list.

Jiaocz
Jiaocz reviewed Sep 21, 2021
View reviewed changes
README.md Outdated


# Requirements
1.Python or PHP
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a space after "1."

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for telling me :D

Jiaocz
Jiaocz approved these changes Sep 22, 2021
View reviewed changes
Copy link

@Jiaocz Jiaocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🌟

@LeontKing2
Copy link
Author

Added Some docker image stuff :D

@LeontKing2
Copy link
Author

OMG DOCKER FINALLY WORKED!!!

@LeontKing2
Copy link
Author

Test

@LeontKing2
Copy link
Author

LeontKing2 commented Nov 4, 2021 •
edited
Loading

Credits to @jweaver0312 for style.php and index.php and support for chromium and webkit

Daniellop1
Daniellop1 approved these changes Dec 20, 2021
View reviewed changes
Copy link

@Daniellop1 Daniellop1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeontKing2
Copy link
Author

LGTM

Yay :D :D

@LeontKing2
Copy link
Author

will update docker image

@LeontKing2
Copy link
Author

Anyone wanna help fix the alignment? plas

@Ghalbeyou
Copy link

Whats wrong?

@LeontKing2
Copy link
Author

when will this patch ever enter...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daniellop1 Daniellop1 Daniellop1 approved these changes

@Jiaocz Jiaocz Jiaocz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LeontKing2 @Ghalbeyou @Jiaocz @Daniellop1 @jweaver0312