Convert Future to Async #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks great! Thank you kindly @JPonte. 🙏
I think you have one stray println in there...
davesmith00000
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #280
There were 3 similar instances where scala Future/Promises were being used and all of them were similarly converted to
Async[F].async. I didn't find test cases for these but the file readers at least are "covered" in the sandbox project where I could confirm they still work without issues. I added yet another contrived example in the Sandbox for theImageLoader, which wasn't being used anywhere so far, and I'm not entirely sure it's the correct use case for it but at least I can see that it works fine.