Skip to content

Commit

Permalink
more fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
Kagekazu committed Nov 18, 2024
1 parent 3e20b59 commit 1c004fe
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 23 deletions.
5 changes: 0 additions & 5 deletions XIVSlothCombo/Combos/PvE/DRG/DRG.cs
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
using Dalamud.Game.ClientState.JobGauge.Types;
using XIVSlothCombo.Combos.PvE.Content;
using XIVSlothCombo.CustomComboNS;
using XIVSlothCombo.Extensions;
using static XIVSlothCombo.Combos.JobHelpers.DRG;
using static XIVSlothCombo.CustomComboNS.Functions.CustomComboFunctions;

namespace XIVSlothCombo.Combos.PvE;

Expand Down Expand Up @@ -47,8 +44,6 @@ public const uint
SpiralBlow = 36955,
Starcross = 36956;

protected static DRGGauge? Gauge = GetJobGauge<DRGGauge>();

public static class Buffs
{
public const ushort
Expand Down
6 changes: 2 additions & 4 deletions XIVSlothCombo/Combos/PvE/DRG/DRG_Helper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,13 @@
using Dalamud.Game.ClientState.Statuses;
using ECommons.DalamudServices;
using XIVSlothCombo.Combos.JobHelpers.Enums;
using XIVSlothCombo.Combos.PvE;
using XIVSlothCombo.Combos.PvE.Content;
using XIVSlothCombo.Data;
using static XIVSlothCombo.Combos.PvE.DRG;
using static XIVSlothCombo.CustomComboNS.Functions.CustomComboFunctions;

namespace XIVSlothCombo.Combos.JobHelpers;
namespace XIVSlothCombo.Combos.PvE;

internal class DRG
internal partial class DRG
{
// DRG Gauge & Extensions
public static DRGGauge Gauge = GetJobGauge<DRGGauge>();
Expand Down
19 changes: 5 additions & 14 deletions XIVSlothCombo/Combos/PvE/RPR/RPR_Helper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,20 @@
using ECommons.DalamudServices;
using FFXIVClientStructs.FFXIV.Client.Game;
using XIVSlothCombo.Combos.JobHelpers.Enums;
using XIVSlothCombo.Combos.PvE;
using XIVSlothCombo.Data;
using static XIVSlothCombo.Combos.PvE.RPR;
using static XIVSlothCombo.CustomComboNS.Functions.CustomComboFunctions;

namespace XIVSlothCombo.Combos.PvE;

internal partial class RPR
{
// RPR Gauge & Extensions
public static float GCD => GetCooldown(Slice).CooldownTotal;

public static RPROpenerLogic RPROpener = new();

public static RPRGauge Gauge = GetJobGauge<RPRGauge>();

// RPR Gauge & Extensions
public static float GCD => GetCooldown(Slice).CooldownTotal;

public static bool trueNorthReady => TargetNeedsPositionals() && ActionReady(All.TrueNorth) &&
!HasEffect(All.Buffs.TrueNorth);

Expand Down Expand Up @@ -221,15 +220,7 @@ public static unsafe bool IsComboExpiring(float Times)

return ActionManager.Instance()->Combo.Timer != 0 && ActionManager.Instance()->Combo.Timer < GCD;
}

public static bool IsBuffExpiring(float Times)
{
float GCD = GetCooldown(Slice).CooldownTotal * Times;

return (HasEffect(Buffs.EnhancedGallows) && GetBuffRemainingTime(Buffs.EnhancedGallows) < GCD) ||
(HasEffect(Buffs.EnhancedGibbet) && GetBuffRemainingTime(Buffs.EnhancedGibbet) < GCD);
}


public static bool IsDebuffExpiring(float Times)
{
float GCD = GetCooldown(Slice).CooldownTotal * Times;
Expand Down

0 comments on commit 1c004fe

Please sign in to comment.