Dark mode edits

[jukent]

Changing paragraph text back to black in dark mode. Also changing various highlighting in dark mode for better contrast.

Closes #63

[r-ford]

It looks like your edit was reversed by the CI

[jukent]

It passes pre-commit locally, I don't like that our pre-commit.ci is being so aggressive.

[jukent]

Okay I think I caught all of the various dark mode classes for python syntax highlighting. If you catch one let me know.

There is still some weirdness with table coloring. (If I make the tables on https://sphinx-pythia-theme--66.org.readthedocs.build/en/66/reference/special-theme-elements.html look okay, the table on https://sphinx-pythia-theme--66.org.readthedocs.build/en/66/reference/notebooks.html looks bad, I need to figure out what class is the difference between them)

This affects the following CSS:

html[data-theme="dark"] table thead tr {
  background-color: white;
}

html[data-theme="dark"] table tbody tr:nth-child(2n) {
  background-color: white;
}

html[data-theme="dark"] th.head p {
  color: black;
}

[jukent]

Fixed the tables! This is gtg!

[brian-rose]

Hi @jukent, is there a good way to preview this on some of our sites? I don't know much at all about CSS so can't review the code effectively, but I'd be happy to test-drive the updated theme.

[jukent]

Thanks @brian-rose from the ReadtheDocs build, you have to toggle the dark mode sun/moon icon and then click around. Whatever mode was toggled will have affects on the rest of the pages too.

(This is different than when selecting dark-mode in the inspect which will inherent from a default browser theme, which I also accounted for)

https://sphinx-pythia-theme--66.org.readthedocs.build/en/66/about.html

Compare it to the old dark theme here - https://sphinx-pythia-theme.readthedocs.io/en/latest/about.html

[brian-rose]

It's a huge improvement in readability in dark mode, especially for code cells! Nice work @jukent .

Not reviewing the code here, just the functionality. But it looks good to me.

[jukent]

Thanks @brian-rose if we encounter any dark-theme use cases that weren't covered here I can quickly fix them. This covers all the test cases included on the theme website though.