Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8166 Add .py properties file support for BundleWorkflow #8167

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

yiheng-wang-nv
Copy link
Contributor

Fixes #8166 .

Description

A few sentences describing the changes proposed in this pull request.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@KumoLiu
Copy link
Contributor

KumoLiu commented Oct 23, 2024

I also do some refactor in this PR: #8151.
If it's a urgent request, we can merge this PR first and discuss more details later otherwise we can leave it here and after discussion let's combine these two prs. Thanks.

Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@yiheng-wang-nv
Copy link
Contributor Author

I also do some refactor in this PR: #8151. If it's a urgent request, we can merge this PR first and discuss more details later otherwise we can leave it here and after discussion let's combine these two prs. Thanks.

Thanks, It's not urgent as MONAI 1.4 is released, we can discuss more details later

@drbeh
Copy link
Member

drbeh commented Oct 23, 2024

@KumoLiu when would be the timeline for the next MONAI minor release? It would be great if we can include this MR in the next PyPI distribution. Thanks

@KumoLiu
Copy link
Contributor

KumoLiu commented Oct 24, 2024

@KumoLiu when would be the timeline for the next MONAI minor release? It would be great if we can include this MR in the next PyPI distribution. Thanks

Hi @drbeh, currently, we do not have plans to release a minor version. Can discuss about it later. Thanks.

@KumoLiu
Copy link
Contributor

KumoLiu commented Nov 27, 2024

I also do some refactor in this PR: #8151. If it's a urgent request, we can merge this PR first and discuss more details later otherwise we can leave it here and after discussion let's combine these two prs. Thanks.

Thanks, It's not urgent as MONAI 1.4 is released, we can discuss more details later

Hi @yiheng-wang-nv, the relevant refactor pr has been merged. Could you please resolve the conflict and add relevant tests? Then this pr can be reviewed and merged. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

properties_path of BundleWorkflow only support json format
3 participants