Update some authentication related checks #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniElectra
reviewed
Oct 29, 2024
| @@ -137,7 +146,7 @@ class NintendoCertificate { | |||
| this.consoleType = '3ds'; | |||
| } | |||
|
|
|||
| this._verifySignature(); | |||
| this._verifySignatureECDSA(); // * Force it to use the expected certificate type | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #XXX
Changes:
These changes have been hot-patched in the prod servers for a long time now. This PR simply brings them upstream. Changes include:
Basicauth in some endpointsMarking as draft for now since I hate the way the "check the system type" feature was implemented. It's a hack, and I want to change it. There's also a couple open issues now directly relating to tokens which we may want to implement here first before merging? Unsure, would like some opinions.
[Enhancement]: Store tokens in database #107
[Enhancement]: Make (some) tokens use asymmetric cryptography rather than symmetric cryptography #108
I have read and agreed to the Code of Conduct.
I have read and complied with the contributing guidelines.
What I'm implementing was an approved issue.
I have tested all of my changes.