Skip to content

Commit

Permalink
address comments
Browse files Browse the repository at this point in the history
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
  • Loading branch information
nitbharambe committed Oct 24, 2024
1 parent 5b5aff5 commit dc710a7
Showing 1 changed file with 12 additions and 4 deletions.
16 changes: 12 additions & 4 deletions docs/examples/arrow_example.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,16 @@
"Note that the asymmetric type of attribute in power-grid-model has a shape of `(3,)` along with a specific type. These represent the 3 phases of electrical system.\n",
"Hence, special care is required when handling asymmetric attributes. \n",
"\n",
"In this example, we use the respective primitive types for the symmetrical attributes and a `FixedSizeListArray` of the primitive types with length 3 for asymmetrical attributes. This results in them being stored as contiguous memory which would enable zero-copy conversion. Other possible solutions to this problem are beyond the scope of this example."
"In this example, we use the respective primitive types for the symmetrical attributes and a `FixedSizeListArray` of the primitive types with length 3 for asymmetrical attributes. This results in them being stored as contiguous memory which would enable zero-copy conversion. Other possible workarounds to this are possible, but are beyond the scope of this example."
]
},
{
"cell_type": "code",
"execution_count": null,
"metadata": {},
"outputs": [],
"source": []
},
{
"cell_type": "markdown",
"metadata": {},
Expand Down Expand Up @@ -270,11 +277,11 @@
"source": [
"### Convert the Arrow data to power-grid-model input data\n",
"\n",
"The Arrow record batch or tables can then be converted to row based data or columnar data.\n",
"The Arrow `RecordBatch` or `Table` can then be converted to row based data or columnar data.\n",
"Converting Arrow data to columnar NumPy arrays is recommended to leverage the columnar nature of Arrow data. \n",
"This conversion can be done with zero-copy operations.\n",
"\n",
"A similar approach be adopted by the user to convert to row based data."
"A similar approach can be adopted by the user to convert to row based data instead."
]
},
{
Expand Down Expand Up @@ -468,7 +475,8 @@
"cell_type": "markdown",
"metadata": {},
"source": [
"Converting symmetrical results is straightforward by using schema from [Creating Schema](#creating-a-schema)"
"Converting symmetrical results is straightforward by using schema from [Creating Schema](#creating-a-schema)\n",
"Using types other than the ones from this schema might make a copy of the data. "
]
},
{
Expand Down

0 comments on commit dc710a7

Please sign in to comment.