nix: fix postgrest-dump-schema with optional yaml output #3304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nix/tools/tests.nix
Outdated
Comment on lines
94
to
97
| docs = "Dump the loaded schema's SchemaCache as a yaml file."; | ||
| docs = "Dump the loaded schema's SchemaCache in JSON or Yaml format."; | ||
| args = [ | ||
| "ARG_OPTIONAL_BOOLEAN([yaml], [y], [Dump the schema cache in Yaml format])" | ||
| ]; |
There was a problem hiding this comment.
I think you can just remove the YAML option entirely. The reason for its introduction was because we intended to use it to commit a dump of the schema cache to the repo and then have the diff for that as a kind of test. This was discussed in #1699, but has since been superseded by the new snapshot IO test.
It's fine to output JSON only, which is easier to work with for local development / debugging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I'm using
--dump-schemaa lot for the test schema, I noticed this command existed but was outdated.