feat: log schema cache load time

PostgREST · Feb 21, 2024 · 3a3601c · 3a3601c
1 parent 1a141c1
commit 3a3601c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,7 +10,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
  - #2887, Add Preference `max-affected` to limit affected resources - @taimoorzaeem
  - #3171, Add an ability to dump config via admin API - @skywriter
  - #3061, Apply all function settings as transaction-scoped settings - @taimoorzaeem
- - #3171, Log schema cache stats to stderr - @steve-chavez
+ - #3171, #3046, Log schema cache stats to stderr - @steve-chavez
  - #3210, Dump schema cache through admin API - @taimoorzaeem
 
 ### Fixed

diff --git a/src/PostgREST/AppState.hs b/src/PostgREST/AppState.hs
@@ -310,7 +310,8 @@ loadSchemaCache appState observer = do
     Right sCache -> do
       putSchemaCache appState $ Just sCache
       observer $ SchemaCacheQueriedObs resultTime
-      observer $ SchemaCacheLoadedObs sCache
+      (t, _) <- timeItT $ observer $ SchemaCacheSummaryObs sCache
+      observer $ SchemaCacheLoadedObs t
       return SCLoaded
 
 -- | Current database connection status data ConnectionStatus

diff --git a/src/PostgREST/Observation.hs b/src/PostgREST/Observation.hs
@@ -31,7 +31,8 @@ data Observation
   | SchemaCacheFatalErrorObs SQL.UsageError Text
   | SchemaCacheNormalErrorObs SQL.UsageError
   | SchemaCacheQueriedObs Double
-  | SchemaCacheLoadedObs SchemaCache
+  | SchemaCacheSummaryObs SchemaCache
+  | SchemaCacheLoadedObs Double
   | ConnectionRetryObs Int
   | ConnectionPgVersionErrorObs SQL.UsageError
   | DBListenerStart Text
@@ -70,8 +71,10 @@ observationMessage = \case
     "An error ocurred when loading the schema cache. " <> jsonMessage usageErr
   SchemaCacheQueriedObs resultTime ->
     "Schema cache queried in " <> showMillis resultTime  <> " milliseconds"
-  SchemaCacheLoadedObs sCache ->
+  SchemaCacheSummaryObs sCache ->
     "Schema cache loaded " <> showSummary sCache
+  SchemaCacheLoadedObs resultTime ->
+    "Schema cache loaded in " <> showMillis resultTime <> " milliseconds"
   ConnectionRetryObs delay ->
     "Attempting to reconnect to the database in " <> (show delay::Text) <> " seconds..."
   ConnectionPgVersionErrorObs usageErr ->