-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autocapture): auto capture element interactions #224
Conversation
Yeah, I can add some on config, sanitization and potentially swizzling. For the rest, not sure it's going to be effective without diving into UI tests? |
I'd not focus on UI tests now, just the bits that are possible via unit tests but still asserting/testing the feature. |
# Conflicts: # CHANGELOG.md
runs are failing on CI both for make test and make test-ios. Will address in another PR
Working on the docs made me realize that this new configuration could be confusing to the users. We already have Currently, the config looks like this: config.autocapture = true // $autocapture support
config.autocaptureConfig = true // configuration for autocapture element interactions
config.captureApplicationLifecycleEvents = true // Application Opened etc
config.captureScreenViews = true // $screen support Ideally, all of these configs should be nested in config.captureApplicationLifecycleEvents = true // Application Open etc
config.captureScreenViews = true // $screen support
config.captureInteractions = true // $autocapture support Once this is battle tested we can think about nesting or grouping the configurations. What do you guys think? @marandaneto @pauldambra |
While I agree with the confusion, JS is the same, see https://posthog.com/docs/product-analytics/autocapture
how does that sound? it was probably my mistake to call such events "autocapture" as well because it was unclear to me that autocapture was only about the $autocapture events that are only captured for the control events. |
Yeah, I see that JS distinguishes in a similar way between However, in the intro section of the docs, under Autocapture, pageview and screen are included. I think this is what throws me off a bit for both. It's only until you get to Disabling autocapture section that it becomes a bit clear that
I think I'll go with your suggestion for now, keep this as-is, and rework the docs a bit. But in general I think we need to clear this up in both libs. If we don't want to combine all events under "Autocapture", then maybe it's better if we start calling "Application Open", "Page view", "Page leave" "Screen" etc as |
@ioannisj it's a good point, I also noticed that when reading it again. |
# Conflicts: # CHANGELOG.md # PostHogTests/PostHogSDKTest.swift
@marandaneto updated docs. See links in body |
# Conflicts: # CHANGELOG.md # PostHogTests/PostHogSDKTest.swift
# Conflicts: # CHANGELOG.md
💡 Motivation and Context
Autocapture feature for iOS (UIKit)
FE: PostHog/posthog#25763, PostHog/posthog#25996
Docs: PostHog/posthog.com#9783
Elements
Gestures
💚 How did you test it?
📝 Checklist