Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saskatchewan Dividend Tax Credit #457

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Saskatchewan Dividend Tax Credit #457

wants to merge 14 commits into from

Conversation

Yaohhhh
Copy link
Contributor

@Yaohhhh Yaohhhh commented Oct 12, 2023

Fixed #456

@Yaohhhh Yaohhhh marked this pull request as ready for review October 12, 2023 22:44
PavelMakarchuk
PavelMakarchuk requested changes Nov 14, 2023
View reviewed changes
changelog_entry.yaml Outdated Show resolved Hide resolved
...parameters/gov/provinces/sk/tax/income/credits/dividend_tax_credit/eligible_cal_percent.yaml Outdated Show resolved Hide resolved
...parameters/gov/provinces/sk/tax/income/credits/dividend_tax_credit/eligible_cal_percent.yaml Outdated Show resolved Hide resolved
policyengine_canada/tests/gov/provinces/sk/tax/income/credits/sk_dividend_tax_credit.yaml Outdated Show resolved Hide resolved
...les/gov/provinces/sk/tax/income/credits/sk_dividend_tax_credit/sk_total_taxable_dividends.py Outdated Show resolved Hide resolved
...les/gov/provinces/sk/tax/income/credits/sk_dividend_tax_credit/sk_total_taxable_dividends.py Outdated Show resolved Hide resolved
...ces/sk/tax/income/credits/sk_dividend_tax_credit/sk_other_than_eligible_taxable_dividends.py Outdated Show resolved Hide resolved
...ces/sk/tax/income/credits/sk_dividend_tax_credit/sk_other_than_eligible_taxable_dividends.py Outdated Show resolved Hide resolved
...ces/sk/tax/income/credits/sk_dividend_tax_credit/sk_other_than_eligible_taxable_dividends.py Outdated Show resolved Hide resolved
...riables/gov/provinces/sk/tax/income/credits/sk_dividend_tax_credit/sk_dividend_tax_credit.py Outdated Show resolved Hide resolved
MaxGhenis
MaxGhenis requested changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "other than eligible" mean here? Isn't there just taxable and tax-exempt dividend income? Please name parameters and Python variables consistently if so.

I'm surprised a credit would be based on the difference between taxable and tax-exempt dividends. Please support that with links to the return where lines 12000 and 12010 are defined.

@PavelMakarchuk
Copy link
Collaborator

What does "other than eligible" mean here? Isn't there just taxable and tax-exempt dividend income? Please name parameters and Python variables consistently if so.

I'm surprised a credit would be based on the difference between taxable and tax-exempt dividends. Please support that with links to the return where lines 12000 and 12010 are defined.

according to this source eligible and other than eligible dividends both refer to taxable dividend income. Eligible dividend income is "generally received from public corporations, earning over $500,000" while other than eligible dividends are received from small businesses (under ~$500,000). Due to the higher corporate rate of larger corporations, eligible dividends are taxed more favorably compared to other than eligible

@MaxGhenis
Copy link
Contributor

thanks for the context. seems like non-eligible is the conventional term

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YiweiJ YiweiJ YiweiJ left review comments

@MaxGhenis MaxGhenis MaxGhenis requested changes

@PavelMakarchuk PavelMakarchuk Awaiting requested review from PavelMakarchuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Saskatchewan Dividend Tax Credit
4 participants
@Yaohhhh @PavelMakarchuk @MaxGhenis @YiweiJ