Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quebec Solidarity Tax Credit #359

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Quebec Solidarity Tax Credit #359

wants to merge 23 commits into from

Conversation

Shinuing
Copy link
Collaborator

Fixes #355

@Shinuing Shinuing self-assigned this Jun 23, 2023
@Shinuing Shinuing marked this pull request as ready for review June 25, 2023 20:50
MaxGhenis
MaxGhenis requested changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add legal references, or leave a comment in each parameter file indicating that they're unavailable.

...s/gov/provinces/qc/tax/income/credits/solidarity/northern_village_component/base_amount.yaml Outdated Show resolved Hide resolved
policyengine_canada/variables/gov/provinces/qc/qc_living_in_northern_villages.py Outdated Show resolved Hide resolved
policyengine_canada/variables/gov/provinces/qc/tax/qc_sales_tax.py Show resolved Hide resolved
...canada/variables/gov/provinces/qc/tax/income/credits/solidarity/qc_solidarity_eligibility.py Outdated Show resolved Hide resolved
...canada/variables/gov/provinces/qc/tax/income/credits/solidarity/qc_solidarity_eligibility.py Outdated Show resolved Hide resolved
...canada/variables/gov/provinces/qc/tax/income/credits/solidarity/qc_solidarity_eligibility.py Show resolved Hide resolved
...canada/variables/gov/provinces/qc/tax/income/credits/solidarity/qc_solidarity_eligibility.py Show resolved Hide resolved
@Shinuing
Copy link
Collaborator Author

Please also add legal references, or leave a comment in each parameter file indicating that they're unavailable.

added!

MaxGhenis
MaxGhenis requested changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@MaxGhenis MaxGhenis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here’s the legal reference, please cite it throughout: https://www.canlii.org/en/qc/laws/stat/cqlr-c-i-3/latest/cqlr-c-i-3.html#se:1029_8_116_12

I found it by asking ChatGPT: https://chat.openai.com/share/a68bd653-c6ab-4b9b-9074-fc2cc6c27dde

Then searching for the Quebec Taxation Act per the listed document: https://ised-isde.canada.ca/site/office-superintendent-bankruptcy/en/licensed-insolvency-trustees/osb-position-papers/treatment-quebec-solidarity-tax-credit-under-bankruptcy-and-insolvency-act

@Shinuing
Copy link
Collaborator Author

Shinuing commented Jun 29, 2023 •
edited
Loading

Here’s the legal reference, please cite it throughout: https://www.canlii.org/en/qc/laws/stat/cqlr-c-i-3/latest/cqlr-c-i-3.html#se:1029_8_116_12

Yes! I have already cited from this site. However, the Act is for 2012, so not all parameters apply! I have cited the parts that remain unchanged, such as age eligibility, reduction rate, etc.

@MaxGhenis
Copy link
Contributor

Please cite the legal code even if the parameters are outdated due to inflation adjustments, to indicate the legal structure of the program and how the parameter fits in.

@Shinuing
Copy link
Collaborator Author

Please cite the legal code even if the parameters are outdated due to inflation adjustments, to indicate the legal structure of the program and how the parameter fits in.

Thank you for letting me know! Fixed！

MaxGhenis
MaxGhenis requested changes Jul 4, 2023
View reviewed changes
...gine_canada/variables/gov/provinces/qc/tax/income/credits/solidarity/qc_solidarity_credit.py Outdated Show resolved Hide resolved
...gine_canada/variables/gov/provinces/qc/tax/income/credits/solidarity/qc_solidarity_credit.py Outdated Show resolved Hide resolved
...gine_canada/variables/gov/provinces/qc/tax/income/credits/solidarity/qc_solidarity_credit.py Outdated Show resolved Hide resolved
...gine_canada/variables/gov/provinces/qc/tax/income/credits/solidarity/qc_solidarity_credit.py Outdated Show resolved Hide resolved
...arameters/gov/provinces/qc/tax/income/credits/solidarity/housing_component/child_amount.yaml Outdated Show resolved Hide resolved
...ada/parameters/gov/provinces/qc/tax/income/credits/solidarity/qst_and_housing_reduction.yaml Outdated Show resolved Hide resolved
...ada/parameters/gov/provinces/qc/tax/income/credits/solidarity/qst_and_housing_reduction.yaml Outdated Show resolved Hide resolved
...arameters/gov/provinces/qc/tax/income/credits/solidarity/housing_component/child_amount.yaml Outdated Show resolved Hide resolved
...rs/gov/provinces/qc/tax/income/credits/solidarity/maximum_family_income/dependent_child.yaml Outdated Show resolved Hide resolved
.../income/credits/solidarity/maximum_family_income/individual_without_spouse_basic_income.yaml Outdated Show resolved Hide resolved
@Shinuing Shinuing requested a review from MaxGhenis August 8, 2023 16:08
MaxGhenis
MaxGhenis requested changes Aug 8, 2023
View reviewed changes
...parameters/gov/provinces/qc/tax/income/credits/solidarity/amount/northern_village/child.yaml Outdated Show resolved Hide resolved
...engine_canada/parameters/gov/provinces/qc/tax/income/credits/solidarity/amount/qst/base.yaml Outdated Show resolved Hide resolved
...da/parameters/gov/provinces/qc/tax/income/credits/solidarity/eligibility/income/married.yaml Outdated Show resolved Hide resolved
policyengine_canada/variables/gov/provinces/qc/qc_living_in_northern_villages.py Outdated Show resolved Hide resolved
...gine_canada/variables/gov/provinces/qc/tax/income/credits/solidarity/qc_solidarity_credit.py Outdated Show resolved Hide resolved
...gine_canada/variables/gov/provinces/qc/tax/income/credits/solidarity/qc_solidarity_credit.py Show resolved Hide resolved
MaxGhenis
MaxGhenis requested changes Aug 16, 2023
View reviewed changes
.../parameters/gov/provinces/qc/tax/income/credits/solidarity/amount/northern_village/base.yaml Outdated Show resolved Hide resolved
...engine_canada/parameters/gov/provinces/qc/tax/income/credits/solidarity/amount/qst/base.yaml Outdated Show resolved Hide resolved
...anada/parameters/gov/provinces/qc/tax/income/credits/solidarity/amount/qst/living_alone.yaml Outdated Show resolved Hide resolved
...da/parameters/gov/provinces/qc/tax/income/credits/solidarity/eligibility/income/married.yaml Outdated Show resolved Hide resolved
...bles/gov/provinces/qc/tax/income/credits/solidarity/qc_solidarity_northern_village_amount.py Outdated Show resolved Hide resolved
...les/gov/provinces/qc/tax/income/credits/solidarity/qc_solidarity_housing_component_amount.py Outdated Show resolved Hide resolved
MaxGhenis
MaxGhenis reviewed Aug 22, 2023
View reviewed changes
...gine_canada/variables/gov/provinces/qc/tax/income/credits/solidarity/qc_solidarity_credit.py
qst_component + housing_component + northern_village_amount
)

# The credit may be reduced on the basis of the family income and different component eligibility
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you changed the logic here. Could you describe the change you made and how it aligns with the law? Please include legal code snippets.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I made a change based on the law. Let me know if it's reasonable.

According to the Act the reduction is based on the family income and eligible components

  • 3%, if B (housing component) and C (northern village) in the formula have a value equal to zero in respect of the eligible individual for the particular payment period; or
  • 6%, in any other case;

However, SPSD/M (Page 1651-1654) divided the reduction rate to "if eligible for only QST component" and "if eligible for both QST and housing" regardless of whether or not they reside in a northern village. (The previous code followed this guide)

Copy link
Collaborator

@PavelMakarchuk PavelMakarchuk Oct 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MaxGhenis friendly reminder - maybe getting together for a review would be helpful

Shinuing
Shinuing commented Aug 22, 2023
View reviewed changes
...canada/variables/gov/provinces/qc/tax/income/credits/solidarity/qc_solidarity_eligibility.py

eligible = age_eligible | (has_spouse & has_child & emancipated)

# family income eligibility
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, could you help take another look at this family income eligibility? @MaxGhenis

The Revenue Quebec website of calculation the reduction of solidarity credit, it also mentioned that "If your principal residence is located in a northern village, do not take the table into account" which corresponds to the maximum family income table.

Should I assume that household income is not taken into account for the credit eligibility, as long as one lives in a northern village?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MaxGhenis friendly reminder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PavelMakarchuk PavelMakarchuk PavelMakarchuk left review comments

@MaxGhenis MaxGhenis Awaiting requested review from MaxGhenis

Assignees

@Shinuing Shinuing

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Quebec Solidarity Tax Credit
3 participants
@Shinuing @MaxGhenis @PavelMakarchuk